Re: [PATCH] sparc64: Add preprocessor symbols for PAGE_* pgprot_t values.

2014-11-03 Thread David Miller
From: Clemens Ladisch Date: Mon, 03 Nov 2014 10:44:40 +0100 > David Miller wrote: >> I'd also rather the kernel use Kconfig based symbols to detect for >> arch availability of feature X or Y, assuming things are CPP symbols >> is very fragile at best. > > It is certainly possible to use

Re: [PATCH] sparc64: Add preprocessor symbols for PAGE_* pgprot_t values.

2014-11-03 Thread Clemens Ladisch
David Miller wrote: >> Kernel code assumes that the PAGE_* values are preprocessor symbols, and >> that therefore arch support can be checked for with #ifdef. >> >> At the moment, sparc64 does not implement any of the symbols checked >> for, so these checks happen to work. >> >> To prevent

Re: [PATCH] sparc64: Add preprocessor symbols for PAGE_* pgprot_t values.

2014-11-03 Thread Clemens Ladisch
David Miller wrote: Kernel code assumes that the PAGE_* values are preprocessor symbols, and that therefore arch support can be checked for with #ifdef. At the moment, sparc64 does not implement any of the symbols checked for, so these checks happen to work. To prevent potential breakage

Re: [PATCH] sparc64: Add preprocessor symbols for PAGE_* pgprot_t values.

2014-11-03 Thread David Miller
From: Clemens Ladisch clem...@ladisch.de Date: Mon, 03 Nov 2014 10:44:40 +0100 David Miller wrote: I'd also rather the kernel use Kconfig based symbols to detect for arch availability of feature X or Y, assuming things are CPP symbols is very fragile at best. It is certainly possible to

Re: [PATCH] sparc64: Add preprocessor symbols for PAGE_* pgprot_t values.

2014-11-02 Thread David Miller
From: Clemens Ladisch Date: Sun, 02 Nov 2014 21:15:12 +0100 > Kernel code assumes that the PAGE_* values are preprocessor symbols, and > that therefore arch support can be checked for with #ifdef. > > At the moment, sparc64 does not implement any of the symbols checked > for, so these checks

[PATCH] sparc64: Add preprocessor symbols for PAGE_* pgprot_t values.

2014-11-02 Thread Clemens Ladisch
Kernel code assumes that the PAGE_* values are preprocessor symbols, and that therefore arch support can be checked for with #ifdef. At the moment, sparc64 does not implement any of the symbols checked for, so these checks happen to work. To prevent potential breakage when another #ifdef check

[PATCH] sparc64: Add preprocessor symbols for PAGE_* pgprot_t values.

2014-11-02 Thread Clemens Ladisch
Kernel code assumes that the PAGE_* values are preprocessor symbols, and that therefore arch support can be checked for with #ifdef. At the moment, sparc64 does not implement any of the symbols checked for, so these checks happen to work. To prevent potential breakage when another #ifdef check

Re: [PATCH] sparc64: Add preprocessor symbols for PAGE_* pgprot_t values.

2014-11-02 Thread David Miller
From: Clemens Ladisch clem...@ladisch.de Date: Sun, 02 Nov 2014 21:15:12 +0100 Kernel code assumes that the PAGE_* values are preprocessor symbols, and that therefore arch support can be checked for with #ifdef. At the moment, sparc64 does not implement any of the symbols checked for, so