Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-28 Thread Arnd Bergmann
On Monday 28 July 2014 16:34:04 Andy Shevchenko wrote: > On Mon, 2014-07-28 at 14:47 +0200, Arnd Bergmann wrote: > > On Monday 28 July 2014 14:06:20 Andy Shevchenko wrote: > > static bool atmci_filter(struct dma_chan *chan, void *pdata) > > { > > struct mci_platform_data *sl_pdata = pdata;

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-28 Thread Andy Shevchenko
On Mon, 2014-07-28 at 14:47 +0200, Arnd Bergmann wrote: > On Monday 28 July 2014 14:06:20 Andy Shevchenko wrote: > > On Fri, 2014-07-25 at 17:55 +0200, Arnd Bergmann wrote: > > > On Friday 25 July 2014 13:45:47 Andy Shevchenko wrote: > > > > On Fri, 2014-07-25 at 12:19 +0200, Arnd Bergmann wrote: >

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-28 Thread Arnd Bergmann
On Monday 28 July 2014 14:06:20 Andy Shevchenko wrote: > On Fri, 2014-07-25 at 17:55 +0200, Arnd Bergmann wrote: > > On Friday 25 July 2014 13:45:47 Andy Shevchenko wrote: > > > On Fri, 2014-07-25 at 12:19 +0200, Arnd Bergmann wrote: > > > > On Friday 25 July 2014 12:55:59 Mika Westerberg wrote: >

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-28 Thread Shevchenko, Andriy
On Mon, 2014-07-28 at 14:06 +0300, Andy Shevchenko wrote: > On Fri, 2014-07-25 at 17:55 +0200, Arnd Bergmann wrote: > > On Friday 25 July 2014 13:45:47 Andy Shevchenko wrote: [] > > > > What I think you got wrong here (by following my bad advice) is the > > > > master > > > > number. Looking at

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-28 Thread Andy Shevchenko
On Fri, 2014-07-25 at 17:55 +0200, Arnd Bergmann wrote: > On Friday 25 July 2014 13:45:47 Andy Shevchenko wrote: > > On Fri, 2014-07-25 at 12:19 +0200, Arnd Bergmann wrote: > > > On Friday 25 July 2014 12:55:59 Mika Westerberg wrote: > > > > On Fri, Jul 25, 2014 at 12:07:14PM +0300, Mika Westerberg

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-28 Thread Mika Westerberg
On Fri, Jul 25, 2014 at 12:19:02PM +0200, Arnd Bergmann wrote: > On Friday 25 July 2014 12:55:59 Mika Westerberg wrote: > > On Fri, Jul 25, 2014 at 12:07:14PM +0300, Mika Westerberg wrote: > > > On Fri, Jul 25, 2014 at 10:38:36AM +0200, Arnd Bergmann wrote: > > > > On Friday 25 July 2014 11:22:49 M

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-25 Thread One Thousand Gnomes
> The current plan I think is to convert all platforms to use DT > or ACPI so they get the right data from tables passed by the > platform. I'm a bit puzzled about why Intel wants to support the > non-ACPI non-DT case again. If we have to support this case anyway, > what good will ACPI do us on tho

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-25 Thread Arnd Bergmann
On Friday 25 July 2014 13:45:47 Andy Shevchenko wrote: > On Fri, 2014-07-25 at 12:19 +0200, Arnd Bergmann wrote: > > On Friday 25 July 2014 12:55:59 Mika Westerberg wrote: > > > On Fri, Jul 25, 2014 at 12:07:14PM +0300, Mika Westerberg wrote: > > > > On Fri, Jul 25, 2014 at 10:38:36AM +0200, Arnd B

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-25 Thread Andy Shevchenko
On Fri, 2014-07-25 at 12:19 +0200, Arnd Bergmann wrote: > On Friday 25 July 2014 12:55:59 Mika Westerberg wrote: > > On Fri, Jul 25, 2014 at 12:07:14PM +0300, Mika Westerberg wrote: > > > On Fri, Jul 25, 2014 at 10:38:36AM +0200, Arnd Bergmann wrote: > > > > On Friday 25 July 2014 11:22:49 Mika Wes

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-25 Thread Arnd Bergmann
On Friday 25 July 2014 12:55:59 Mika Westerberg wrote: > On Fri, Jul 25, 2014 at 12:07:14PM +0300, Mika Westerberg wrote: > > On Fri, Jul 25, 2014 at 10:38:36AM +0200, Arnd Bergmann wrote: > > > On Friday 25 July 2014 11:22:49 Mika Westerberg wrote: > > > > > All you need to do is change your filte

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-25 Thread Mika Westerberg
On Fri, Jul 25, 2014 at 12:07:14PM +0300, Mika Westerberg wrote: > On Fri, Jul 25, 2014 at 10:38:36AM +0200, Arnd Bergmann wrote: > > On Friday 25 July 2014 11:22:49 Mika Westerberg wrote: > > > > All you need to do is change your filter function to take the > > > > slave id from pxa_spi_info and s

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-25 Thread Mika Westerberg
On Fri, Jul 25, 2014 at 10:38:36AM +0200, Arnd Bergmann wrote: > On Friday 25 July 2014 11:22:49 Mika Westerberg wrote: > > > All you need to do is change your filter function to take the > > > slave id from pxa_spi_info and stick it in there, e.g. > > > > > > static bool pxa2xx_spi_dw_dma_filter(

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-25 Thread Arnd Bergmann
On Friday 25 July 2014 11:22:49 Mika Westerberg wrote: > > All you need to do is change your filter function to take the > > slave id from pxa_spi_info and stick it in there, e.g. > > > > static bool pxa2xx_spi_dw_dma_filter(struct dma_chan *chan, void *param) > > { > > const struct

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-25 Thread Mika Westerberg
On Fri, Jul 25, 2014 at 09:58:42AM +0200, Arnd Bergmann wrote: > On Friday 25 July 2014 10:11:38 Mika Westerberg wrote: > > On Thu, Jul 24, 2014 at 05:06:20PM +0300, Mika Westerberg wrote: > > > > On a related note, there seems to be a bug in this driver, which > > > > attempts to set the slave_id

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-25 Thread Arnd Bergmann
On Friday 25 July 2014 10:11:38 Mika Westerberg wrote: > On Thu, Jul 24, 2014 at 05:06:20PM +0300, Mika Westerberg wrote: > > > On a related note, there seems to be a bug in this driver, which > > > attempts to set the slave_id through dmaengine_slave_config(), which > > > is wrong in both cases, A

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-25 Thread Mika Westerberg
On Thu, Jul 24, 2014 at 05:06:20PM +0300, Mika Westerberg wrote: > > On a related note, there seems to be a bug in this driver, which > > attempts to set the slave_id through dmaengine_slave_config(), which > > is wrong in both cases, ACPI and filter functions. > > Good point. We will fix this, th

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-24 Thread Mika Westerberg
On Thu, Jul 24, 2014 at 01:42:10PM +0200, Arnd Bergmann wrote: > On Thursday 24 July 2014 18:01:51 Kweh Hock Leong wrote: > > From: "Chew, Chiau Ee" > > > > Intel LPSS Baytrail supports two DMA controllers and SPI is only > > using one of the DMA controller. During DMA channel request, > > we nee

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-24 Thread Arnd Bergmann
On Thursday 24 July 2014 18:01:51 Kweh Hock Leong wrote: > From: "Chew, Chiau Ee" > > Intel LPSS Baytrail supports two DMA controllers and SPI is only > using one of the DMA controller. During DMA channel request, > we need to ensure the requested Tx and Rx channels are from the correct > DMA con

Re: [PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-24 Thread Andy Shevchenko
On Thu, 2014-07-24 at 18:01 +0800, Kweh Hock Leong wrote: > From: "Chew, Chiau Ee" > > Intel LPSS Baytrail supports two DMA controllers and SPI is only > using one of the DMA controller. During DMA channel request, > we need to ensure the requested Tx and Rx channels are from the correct > DMA co

[PATCH] spi/pxa2xx-pci: Enable DMA binding through device name

2014-07-24 Thread Kweh Hock Leong
From: "Chew, Chiau Ee" Intel LPSS Baytrail supports two DMA controllers and SPI is only using one of the DMA controller. During DMA channel request, we need to ensure the requested Tx and Rx channels are from the correct DMA controller. Thus, we add extra checking in filter callback funtion by ma