Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

2016-03-05 Thread Mark Brown
On Fri, Feb 26, 2016 at 10:31:50AM +0800, Huang, Tao wrote: > You misunderstand me. I talk about spi_setup, as > Documentation/spi/spi-summary, which would normally be called from > probe() before the first I/O is done to the device. > spi_setup will call spi_set_cs(spi, false), which introduced

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

2016-03-05 Thread Mark Brown
On Fri, Feb 26, 2016 at 10:31:50AM +0800, Huang, Tao wrote: > You misunderstand me. I talk about spi_setup, as > Documentation/spi/spi-summary, which would normally be called from > probe() before the first I/O is done to the device. > spi_setup will call spi_set_cs(spi, false), which introduced

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

2016-02-25 Thread Huang, Tao
On 2016年02月26日 09:58, Mark Brown wrote: > >> Another way to solve this bug is add runtime PM support while spi setup. >> Some other chips may have some problem, for example mt65xx and orion, >> which access hardware register too. > > No, this is telling you you're doing something wrong - setup()

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

2016-02-25 Thread Huang, Tao
On 2016年02月26日 09:58, Mark Brown wrote: > >> Another way to solve this bug is add runtime PM support while spi setup. >> Some other chips may have some problem, for example mt65xx and orion, >> which access hardware register too. > > No, this is telling you you're doing something wrong - setup()

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

2016-02-25 Thread Mark Brown
On Wed, Feb 24, 2016 at 07:09:57PM +0800, Huang, Tao wrote: Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

2016-02-25 Thread Mark Brown
On Wed, Feb 24, 2016 at 07:09:57PM +0800, Huang, Tao wrote: Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

2016-02-24 Thread Huang, Tao
Hi, Mark: Another way to solve this bug is add runtime PM support while spi setup. Some other chips may have some problem, for example mt65xx and orion, which access hardware register too. On 2016年02月24日 18:00, Huibin Hong wrote: > Rockchip_spi_set_cs could be called by spi_setup, but >

Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

2016-02-24 Thread Huang, Tao
Hi, Mark: Another way to solve this bug is add runtime PM support while spi setup. Some other chips may have some problem, for example mt65xx and orion, which access hardware register too. On 2016年02月24日 18:00, Huibin Hong wrote: > Rockchip_spi_set_cs could be called by spi_setup, but >

[PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

2016-02-24 Thread Huibin Hong
Rockchip_spi_set_cs could be called by spi_setup, but spi_setup may be called by device driver after runtime suspend. Then the spi clock is closed, rockchip_spi_set_cs may access the spi registers, which causes cpu block in some socs. Fixes: 64e36824b32 ("spi/rockchip: add driver for Rockchip

[PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set_cs

2016-02-24 Thread Huibin Hong
Rockchip_spi_set_cs could be called by spi_setup, but spi_setup may be called by device driver after runtime suspend. Then the spi clock is closed, rockchip_spi_set_cs may access the spi registers, which causes cpu block in some socs. Fixes: 64e36824b32 ("spi/rockchip: add driver for Rockchip