Re: [PATCH] spi: Avoid calling spi_slave_abort() with kfreed spidev

2019-10-01 Thread Mark Brown
On Tue, Oct 01, 2019 at 12:00:07PM +0200, Geert Uytterhoeven wrote: > On Tue, Oct 1, 2019 at 11:34 AM Lukasz Majewski wrote: > > > On Tue, Oct 1, 2019 at 11:07 AM Lukasz Majewski wrote: > > The if (!dofree) prevents from calling spi_slave_abort() when > > spidev->spi == NULL and spidev is kfree'

Re: [PATCH] spi: Avoid calling spi_slave_abort() with kfreed spidev

2019-10-01 Thread Lukasz Majewski
Hi Geert, > Hi Lukasz, > > On Tue, Oct 1, 2019 at 11:34 AM Lukasz Majewski wrote: > > > On Tue, Oct 1, 2019 at 11:07 AM Lukasz Majewski > > > wrote: > > > > Call spi_slave_abort() only when the spidev->spi is !NULL and > > > > the structure hasn't already been kfreed. > > > > > > > > Reported

Re: [PATCH] spi: Avoid calling spi_slave_abort() with kfreed spidev

2019-10-01 Thread Geert Uytterhoeven
Hi Lukasz, On Tue, Oct 1, 2019 at 11:34 AM Lukasz Majewski wrote: > > On Tue, Oct 1, 2019 at 11:07 AM Lukasz Majewski wrote: > > > Call spi_slave_abort() only when the spidev->spi is !NULL and the > > > structure hasn't already been kfreed. > > > > > > Reported-by: kbuild test robot > > > Repor

Re: [PATCH] spi: Avoid calling spi_slave_abort() with kfreed spidev

2019-10-01 Thread Lukasz Majewski
Hi Geert, Thank you for a very prompt response. > Hi Lukasz, > > On Tue, Oct 1, 2019 at 11:07 AM Lukasz Majewski wrote: > > Call spi_slave_abort() only when the spidev->spi is !NULL and the > > structure hasn't already been kfreed. > > > > Reported-by: kbuild test robot > > Reported-by: Julia

Re: [PATCH] spi: Avoid calling spi_slave_abort() with kfreed spidev

2019-10-01 Thread Geert Uytterhoeven
Hi Lukasz, On Tue, Oct 1, 2019 at 11:07 AM Lukasz Majewski wrote: > Call spi_slave_abort() only when the spidev->spi is !NULL and the > structure hasn't already been kfreed. > > Reported-by: kbuild test robot > Reported-by: Julia Lawall > Reported-by: Dan Carpenter > Signed-off-by: Lukasz Maje

[PATCH] spi: Avoid calling spi_slave_abort() with kfreed spidev

2019-10-01 Thread Lukasz Majewski
Call spi_slave_abort() only when the spidev->spi is !NULL and the structure hasn't already been kfreed. Reported-by: kbuild test robot Reported-by: Julia Lawall Reported-by: Dan Carpenter Signed-off-by: Lukasz Majewski --- This fix applies on: repo: https://kernel.googlesource.com/pub/scm/lin