Re: [PATCH] spi: Initialize variable to prevent uninitialized warning

2014-08-07 Thread Mark Brown
On Wed, Aug 06, 2014 at 10:22:19PM -0700, Guenter Roeck wrote: > So if we ever hit that uninitialized case, where bits_per_word is > neither 8 nor 16, we'll have ops set to NULL and end up wondering > why the kernel crashes a bit further down in the code. Not really > sure if that is an improvemen

Re: [PATCH] spi: Initialize variable to prevent uninitialized warning

2014-08-06 Thread Guenter Roeck
On Thu, Aug 07, 2014 at 06:51:00AM +0200, Nick Krause wrote: > While compiling we see the following waring > > drivers/spi/spi-bfin5xx.c: In function 'bfin_spi_pump_transfers': > drivers/spi/spi-bfin5xx.c:695:6: warning: 'cr_width' may be used uninitialized > in this function [-Wuninitialized] >

[PATCH] spi: Initialize variable to prevent uninitialized warning

2014-08-06 Thread Nick Krause
While compiling we see the following waring drivers/spi/spi-bfin5xx.c: In function 'bfin_spi_pump_transfers': drivers/spi/spi-bfin5xx.c:695:6: warning: 'cr_width' may be used uninitialized in this function [-Wuninitialized] Initialize it to prevent the above warning Signed-off-by: Nick Krause -