Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Lukas Wunner
On Fri, May 29, 2020 at 11:03:48AM -0700, Florian Fainelli wrote: > On 5/29/20 10:53 AM, Lukas Wunner wrote: > > On Fri, May 29, 2020 at 10:46:01AM -0700, Florian Fainelli wrote: > >> On 5/29/20 10:43 AM, Lukas Wunner wrote: > >>> Finally, it would be nice if the check would be optimized away when

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Florian Fainelli
On 5/29/20 10:53 AM, Lukas Wunner wrote: > On Fri, May 29, 2020 at 10:46:01AM -0700, Florian Fainelli wrote: >> On 5/29/20 10:43 AM, Lukas Wunner wrote: >>> On Thu, May 28, 2020 at 08:58:04PM +0200, Nicolas Saenz Julienne wrote: --- a/drivers/spi/spi-bcm2835.c +++ b/drivers/spi/spi-bcm283

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Lukas Wunner
On Fri, May 29, 2020 at 10:46:01AM -0700, Florian Fainelli wrote: > On 5/29/20 10:43 AM, Lukas Wunner wrote: > > On Thu, May 28, 2020 at 08:58:04PM +0200, Nicolas Saenz Julienne wrote: > >> --- a/drivers/spi/spi-bcm2835.c > >> +++ b/drivers/spi/spi-bcm2835.c > >> @@ -379,6 +379,10 @@ static irqretu

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Mark Brown
On Fri, May 29, 2020 at 07:43:58PM +0200, Lukas Wunner wrote: > This definitely looks wrong. The check whether the interrupt is enabled > should be moved *before* the conditional calls to bcm2835_rd_fifo_blind() > and bcm2835_wr_fifo_blind(), i.e. to the top of the function. Hrm, right - I'll dr

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Florian Fainelli
On 5/29/20 10:43 AM, Lukas Wunner wrote: > On Thu, May 28, 2020 at 08:58:04PM +0200, Nicolas Saenz Julienne wrote: >> --- a/drivers/spi/spi-bcm2835.c >> +++ b/drivers/spi/spi-bcm2835.c >> @@ -379,6 +379,10 @@ static irqreturn_t bcm2835_spi_interrupt(int irq, void >> *dev_id) >> if (bs->tx_len

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Lukas Wunner
On Thu, May 28, 2020 at 08:58:04PM +0200, Nicolas Saenz Julienne wrote: > --- a/drivers/spi/spi-bcm2835.c > +++ b/drivers/spi/spi-bcm2835.c > @@ -379,6 +379,10 @@ static irqreturn_t bcm2835_spi_interrupt(int irq, void > *dev_id) > if (bs->tx_len && cs & BCM2835_SPI_CS_DONE) > b

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-29 Thread Mark Brown
On Thu, 28 May 2020 20:58:04 +0200, Nicolas Saenz Julienne wrote: > bcm2711, Rasberry Pi 4's SoC, shares one interrupt for multiple > instances of the bcm2835 SPI controller. So this enables shared > interrupt support for them. > > The early bail out in the interrupt routine avoids messing with bu

Re: [PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-28 Thread Florian Fainelli
On 5/28/20 11:58 AM, Nicolas Saenz Julienne wrote: > From: Martin Sperl > > bcm2711, Rasberry Pi 4's SoC, shares one interrupt for multiple > instances of the bcm2835 SPI controller. So this enables shared > interrupt support for them. > > The early bail out in the interrupt routine avoids messi

[PATCH] spi: bcm2835: Enable shared interrupt support

2020-05-28 Thread Nicolas Saenz Julienne
From: Martin Sperl bcm2711, Rasberry Pi 4's SoC, shares one interrupt for multiple instances of the bcm2835 SPI controller. So this enables shared interrupt support for them. The early bail out in the interrupt routine avoids messing with buffers of transfers being done by other means. Otherwise