Re: [PATCH] spi: rb4xx: Fix set_cs logic.

2015-04-21 Thread Mark Brown
On Tue, Apr 21, 2015 at 01:01:22PM +0200, Bert Vermeulen wrote: > On 04/21/2015 11:46 AM, Geert Uytterhoeven wrote: > > On Mon, Apr 20, 2015 at 10:37 PM, Mark Brown wrote: > >> No, the enable parameter *should* refer to chip select assertion (see > >> how we handle GPIO chip selects). However it

Re: [PATCH] spi: rb4xx: Fix set_cs logic.

2015-04-21 Thread Bert Vermeulen
On 04/21/2015 11:46 AM, Geert Uytterhoeven wrote: > On Mon, Apr 20, 2015 at 10:37 PM, Mark Brown wrote: >> On Mon, Apr 20, 2015 at 03:53:25PM +0200, Bert Vermeulen wrote: >>> As it turns out, the set_cs() enable parameter refers to the logic level >>> on the CS pin, not the state of chip selection

Re: [PATCH] spi: rb4xx: Fix set_cs logic.

2015-04-21 Thread Geert Uytterhoeven
On Mon, Apr 20, 2015 at 10:37 PM, Mark Brown wrote: > On Mon, Apr 20, 2015 at 03:53:25PM +0200, Bert Vermeulen wrote: >> As it turns out, the set_cs() enable parameter refers to the logic level >> on the CS pin, not the state of chip selection. > >> This broke functionality of the LEDs behind the

Re: [PATCH] spi: rb4xx: Fix set_cs logic.

2015-04-20 Thread Mark Brown
On Mon, Apr 20, 2015 at 03:53:25PM +0200, Bert Vermeulen wrote: > As it turns out, the set_cs() enable parameter refers to the logic level > on the CS pin, not the state of chip selection. > This broke functionality of the LEDs behind the CPLD, or at least delayed > the commands until another one

[PATCH] spi: rb4xx: Fix set_cs logic.

2015-04-20 Thread Bert Vermeulen
As it turns out, the set_cs() enable parameter refers to the logic level on the CS pin, not the state of chip selection. This broke functionality of the LEDs behind the CPLD, or at least delayed the commands until another one came in to toggle CS. Signed-off-by: Bert Vermeulen --- drivers/spi/s