On Wed, Dec 13, 2017 at 10:48:54AM +0900, Andi Shyti wrote:
> > > +//
> > > +// Copyright (c) 2009 Samsung Electronics Co., Ltd.
> > > +// Jaswinder Singh
> it just looks ugly to me to have something like
> // SPDX...
> /*
>* Copyright (c)...
>* Jasw...
>*/
> I would
On Wed, Dec 13, 2017 at 2:48 AM, Andi Shyti wrote:
> Hi Krzysztof,
>
>> > Here, this should be as a top line:
>> >
>> > // SPDX-License-Identifier: GPL-2.0+
>> >
>> >
>> > So I agree with the SPDX id but also pointing to the use of the C++ //
>> > comment style as requested by Linus [1]
>>
>> Than
Hi Krzysztof,
> > Here, this should be as a top line:
> >
> > // SPDX-License-Identifier: GPL-2.0+
> >
> >
> > So I agree with the SPDX id but also pointing to the use of the C++ //
> > comment style as requested by Linus [1]
>
> Thanks for the reference. I see that Linus prefers converting entir
On Tue, Dec 12, 2017 at 4:24 PM, Philippe Ombredanne
wrote:
> Dear Krzysztof,
>
> On Tue, Dec 12, 2017 at 4:00 PM, Krzysztof Kozlowski wrote:
>> On Tue, Dec 12, 2017 at 3:48 PM, Philippe Ombredanne
>> wrote:
>>> On Tue, Dec 12, 2017 at 2:45 PM, Krzysztof Kozlowski
>>> wrote:
On Tue, Dec 1
Hi Krzysztof,
> > - * Copyright (C) 2009 Samsung Electronics Ltd.
> > - * Jaswinder Singh
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License as published by
> > - * the Free Software Foundation; eit
Dear Krzysztof,
On Tue, Dec 12, 2017 at 4:00 PM, Krzysztof Kozlowski wrote:
> On Tue, Dec 12, 2017 at 3:48 PM, Philippe Ombredanne
> wrote:
>> On Tue, Dec 12, 2017 at 2:45 PM, Krzysztof Kozlowski wrote:
>>> On Tue, Dec 12, 2017 at 2:03 PM, Andi Shyti wrote:
Hi Krzysztof,
> > - *
On Tue, Dec 12, 2017 at 3:48 PM, Philippe Ombredanne
wrote:
> On Tue, Dec 12, 2017 at 2:45 PM, Krzysztof Kozlowski wrote:
>> On Tue, Dec 12, 2017 at 2:03 PM, Andi Shyti wrote:
>>> Hi Krzysztof,
>>>
> - * Copyright (C) 2009 Samsung Electronics Ltd.
> - * Jaswinder Singh
> - *
On Tue, Dec 12, 2017 at 2:45 PM, Krzysztof Kozlowski wrote:
> On Tue, Dec 12, 2017 at 2:03 PM, Andi Shyti wrote:
>> Hi Krzysztof,
>>
>>> > - * Copyright (C) 2009 Samsung Electronics Ltd.
>>> > - * Jaswinder Singh
>>> > - *
>>> > - * This program is free software; you can redistribute it and/
On Tue, Dec 12, 2017 at 2:03 PM, Andi Shyti wrote:
> Hi Krzysztof,
>
>> > - * Copyright (C) 2009 Samsung Electronics Ltd.
>> > - * Jaswinder Singh
>> > - *
>> > - * This program is free software; you can redistribute it and/or modify
>> > - * it under the terms of the GNU General Public Licen
On Tue, Dec 12, 2017 at 11:13:26AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Dec 12, 2017 at 11:07 AM, Mark Brown wrote:
> > Apparently that's the thing for SPDX headers.
> Yes (although in sources one can find /* */ as well) but the rest of
> comment does not have to be changed in that case.
On Tue, Dec 12, 2017 at 11:07 AM, Mark Brown wrote:
> On Tue, Dec 12, 2017 at 10:17:09AM +0100, Krzysztof Kozlowski wrote:
>> On Tue, Dec 12, 2017 at 8:58 AM, Andi Shyti wrote:
>
>> > +// SPDX-License-Identifier: GPL-2.0
>
>> Why changing the comment style?
>
> Apparently that's the thing for SPD
On Tue, Dec 12, 2017 at 10:17:09AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Dec 12, 2017 at 8:58 AM, Andi Shyti wrote:
> > +// SPDX-License-Identifier: GPL-2.0
> Why changing the comment style?
Apparently that's the thing for SPDX headers.
signature.asc
Description: PGP signature
On Tue, Dec 12, 2017 at 8:58 AM, Andi Shyti wrote:
> Replace the original license statement with the SPDX identifier.
>
> Signed-off-by: Andi Shyti
> ---
> drivers/spi/spi-s3c64xx.c | 18 --
> include/linux/platform_data/spi-s3c64xx.h | 4 +---
> 2 files changed,
Replace the original license statement with the SPDX identifier.
Signed-off-by: Andi Shyti
---
drivers/spi/spi-s3c64xx.c | 18 --
include/linux/platform_data/spi-s3c64xx.h | 4 +---
2 files changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/spi/spi-s
14 matches
Mail list logo
