Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-24 Thread Philipp Zabel
Hi Arnd, thanks for taking the time to clean this up. Am Dienstag, den 24.02.2015, 14:02 +0100 schrieb Arnd Bergmann: > On Tuesday 24 February 2015 16:50:18 Mark Brown wrote: > > On Mon, Feb 23, 2015 at 11:01:18PM +0100, Arnd Bergmann wrote: > > > On Saturday 21 February 2015 18:44:58 Mark Brown

Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-24 Thread Chen-Yu Tsai
On Tue, Feb 24, 2015 at 9:34 PM, Arnd Bergmann wrote: > On Tuesday 24 February 2015 18:56:44 Chen-Yu Tsai wrote: >> > --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig >> > +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig >> > @@ -1,11 +1,11 @@ >> > config STMMAC_ETH >> > tristate "STMic

Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-24 Thread Arnd Bergmann
On Tuesday 24 February 2015 18:56:44 Chen-Yu Tsai wrote: > > --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig > > +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig > > @@ -1,11 +1,11 @@ > > config STMMAC_ETH > > tristate "STMicroelectronics 10/100/1000 Ethernet driver" > > depends

Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-24 Thread Arnd Bergmann
On Tuesday 24 February 2015 16:50:18 Mark Brown wrote: > On Mon, Feb 23, 2015 at 11:01:18PM +0100, Arnd Bergmann wrote: > > On Saturday 21 February 2015 18:44:58 Mark Brown wrote: > > > > In that case a dependency seems wrong, I'd expect to see a select - it's > > > a bit obscure to have to grovel

Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-24 Thread Chen-Yu Tsai
On Tue, Feb 24, 2015 at 6:27 PM, Arnd Bergmann wrote: > On Tuesday 24 February 2015 16:50:18 Mark Brown wrote: >> On Mon, Feb 23, 2015 at 11:01:18PM +0100, Arnd Bergmann wrote: >> > On Saturday 21 February 2015 18:44:58 Mark Brown wrote: >> >> > > In that case a dependency seems wrong, I'd expect

Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-24 Thread Arnd Bergmann
On Tuesday 24 February 2015 16:50:18 Mark Brown wrote: > On Mon, Feb 23, 2015 at 11:01:18PM +0100, Arnd Bergmann wrote: > > On Saturday 21 February 2015 18:44:58 Mark Brown wrote: > > > > In that case a dependency seems wrong, I'd expect to see a select - it's > > > a bit obscure to have to grovel

Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-23 Thread Mark Brown
On Mon, Feb 23, 2015 at 11:01:18PM +0100, Arnd Bergmann wrote: > On Saturday 21 February 2015 18:44:58 Mark Brown wrote: > > In that case a dependency seems wrong, I'd expect to see a select - it's > > a bit obscure to have to grovel around to figure out what magic options > > are needed to make t

Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-23 Thread Arnd Bergmann
On Saturday 21 February 2015 18:44:58 Mark Brown wrote: > On Thu, Feb 19, 2015 at 04:01:29PM +0100, Arnd Bergmann wrote: > > > So the stubs are provided for all functions except device_reset() and > > reset_control_get(), and drivers using the API need to either call the > > stubbed-out _optional(

Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-21 Thread Mark Brown
On Thu, Feb 19, 2015 at 04:01:29PM +0100, Arnd Bergmann wrote: > So the stubs are provided for all functions except device_reset() and > reset_control_get(), and drivers using the API need to either call the > stubbed-out _optional() versions of these functions or have the explicit > dependency.

Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-19 Thread Arnd Bergmann
On Thursday 19 February 2015 18:41:55 Mark Brown wrote: > On Wed, Feb 18, 2015 at 04:29:10PM +0100, Arnd Bergmann wrote: > > > The adds a dependency in Kconfig to prevent it from being selected > > if the resets are not available. > > Why is this a better fix than making the reset controller API

Re: [PATCH] spi: sirf: add reset controller dependency

2015-02-19 Thread Mark Brown
On Wed, Feb 18, 2015 at 04:29:10PM +0100, Arnd Bergmann wrote: > The adds a dependency in Kconfig to prevent it from being selected > if the resets are not available. Why is this a better fix than making the reset controller API stub itself out? It's probably not such a big deal here but for dev

[PATCH] spi: sirf: add reset controller dependency

2015-02-18 Thread Arnd Bergmann
The sirf spi driver only builds correctly if the reset controller framework is available, otherwise we get an error: drivers/spi/spi-sirf.c: In function 'spi_sirfsoc_probe': drivers/spi/spi-sirf.c:651:2: error: implicit declaration of function 'device_reset' [-Werror=implicit-function-declaration