Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

2021-01-11 Thread Mark Brown
On Mon, Jan 11, 2021 at 09:21:11AM -0800, Florian Fainelli wrote: > On 1/11/21 9:05 AM, Mark Brown wrote: > > Honestly for super trivial stuff like this I'm not sure it's a useful > > use of anyone's time to police this sort of stuff aggressively, it's > > after the prefixes that matter so I saw i

Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

2021-01-11 Thread Florian Fainelli
On 1/11/21 9:05 AM, Mark Brown wrote: > On Mon, Jan 11, 2021 at 08:41:19AM -0800, Florian Fainelli wrote: > >>> [1/1] spi: spi-bcm-qspi: style: Simplify bool comparison >>> commit: 6650ab2a44268af8d24995d28ae199b57b2ebff8 > >> I don't think that "style: " is a subject prefix that is used co

Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

2021-01-11 Thread Mark Brown
On Mon, Jan 11, 2021 at 08:41:19AM -0800, Florian Fainelli wrote: > > [1/1] spi: spi-bcm-qspi: style: Simplify bool comparison > > commit: 6650ab2a44268af8d24995d28ae199b57b2ebff8 > I don't think that "style: " is a subject prefix that is used commonly > and it certainly should not belong i

Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

2021-01-11 Thread Florian Fainelli
On 1/11/2021 8:29 AM, Mark Brown wrote: > On Mon, 11 Jan 2021 17:26:29 +0800, YANG LI wrote: >> Fix the following coccicheck warning: >> ./drivers/spi/spi-bcm-qspi.c:884:5-34: WARNING: Comparison to bool > > Applied to > >https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-

Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

2021-01-11 Thread Mark Brown
On Mon, 11 Jan 2021 17:26:29 +0800, YANG LI wrote: > Fix the following coccicheck warning: > ./drivers/spi/spi-bcm-qspi.c:884:5-34: WARNING: Comparison to bool Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-bcm-qspi: style: Simplify

[PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

2021-01-11 Thread YANG LI
Fix the following coccicheck warning: ./drivers/spi/spi-bcm-qspi.c:884:5-34: WARNING: Comparison to bool Signed-off-by: YANG LI Reported-by: Abaci Robot --- drivers/spi/spi-bcm-qspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi

[PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

2021-01-11 Thread YANG LI
Fix the following coccicheck warning: ./drivers/spi/spi-bcm-qspi.c:884:5-34: WARNING: Comparison to bool Signed-off-by: YANG LI Reported-by: Abaci Robot --- drivers/spi/spi-bcm-qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi