Re: [PATCH] spi: spi-davinci: deassert CS on setup()

2013-09-12 Thread Ben Gardiner
Hi Trent, Thanks for the quick review. On Tue, Sep 10, 2013 at 10:44 PM, Trent Piepho wrote: > > It is supposed to be possible to call setup() on one slave while > transfers on another slave attached to the same master are in > progress. > > A cursory look at the code makes it seem that all the

Re: [PATCH] spi: spi-davinci: deassert CS on setup()

2013-09-10 Thread Trent Piepho
It is supposed to be possible to call setup() on one slave while transfers on another slave attached to the same master are in progress. A cursory look at the code makes it seem that all the CS control bits share SPIDAT1? Will writing to SPIDAT1 in davinci_spi_chipselect() cause a race if another

[PATCH] spi: spi-davinci: deassert CS on setup()

2013-09-10 Thread Ben Gardiner
The mmc_spi driver's mmc_cs_off() function states that "chipselect will always be inactive after setup()"; however, the spi-davinci driver's setup() leaves CS state unchanged. Add a call to davinci_spi_chipselect(spi, BITBANG_CS_INACTIVE) to the spi- davinci drivers' setup() function. Signed-off-