Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Mark Brown
On Thu, Oct 04, 2018 at 09:41:20AM -0700, Nick Desaulniers wrote: > On Thu, Oct 4, 2018 at 9:04 AM Nathan Chancellor > > On Thu, Oct 04, 2018 at 11:32:47AM +0100, Mark Brown wrote: > > > Please remember to CC driver maintainers and authors on patch > > > submissions so they can review things,

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Mark Brown
On Thu, Oct 04, 2018 at 09:41:20AM -0700, Nick Desaulniers wrote: > On Thu, Oct 4, 2018 at 9:04 AM Nathan Chancellor > > On Thu, Oct 04, 2018 at 11:32:47AM +0100, Mark Brown wrote: > > > Please remember to CC driver maintainers and authors on patch > > > submissions so they can review things,

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Nathan Chancellor
On Fri, Oct 05, 2018 at 11:28:44AM +0300, Mika Westerberg wrote: > Hi, > > On Thu, Oct 04, 2018 at 11:32:47AM +0100, Mark Brown wrote: > > On Wed, Oct 03, 2018 at 07:39:26PM -0700, Nathan Chancellor wrote: > > > Clang warns when one enumerated type is implicitly converted to another. > > > > > >

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Nathan Chancellor
On Fri, Oct 05, 2018 at 11:28:44AM +0300, Mika Westerberg wrote: > Hi, > > On Thu, Oct 04, 2018 at 11:32:47AM +0100, Mark Brown wrote: > > On Wed, Oct 03, 2018 at 07:39:26PM -0700, Nathan Chancellor wrote: > > > Clang warns when one enumerated type is implicitly converted to another. > > > > > >

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Mika Westerberg
Hi, On Thu, Oct 04, 2018 at 11:32:47AM +0100, Mark Brown wrote: > On Wed, Oct 03, 2018 at 07:39:26PM -0700, Nathan Chancellor wrote: > > Clang warns when one enumerated type is implicitly converted to another. > > > > drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from > >

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Mika Westerberg
Hi, On Thu, Oct 04, 2018 at 11:32:47AM +0100, Mark Brown wrote: > On Wed, Oct 03, 2018 at 07:39:26PM -0700, Nathan Chancellor wrote: > > Clang warns when one enumerated type is implicitly converted to another. > > > > drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from > >

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-04 Thread Nick Desaulniers
On Thu, Oct 4, 2018 at 9:04 AM Nathan Chancellor wrote: > > On Thu, Oct 04, 2018 at 11:32:47AM +0100, Mark Brown wrote: > > On Wed, Oct 03, 2018 at 07:39:26PM -0700, Nathan Chancellor wrote: > > > Clang warns when one enumerated type is implicitly converted to another. > > > > > >

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-04 Thread Nick Desaulniers
On Thu, Oct 4, 2018 at 9:04 AM Nathan Chancellor wrote: > > On Thu, Oct 04, 2018 at 11:32:47AM +0100, Mark Brown wrote: > > On Wed, Oct 03, 2018 at 07:39:26PM -0700, Nathan Chancellor wrote: > > > Clang warns when one enumerated type is implicitly converted to another. > > > > > >

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-04 Thread Nathan Chancellor
On Thu, Oct 04, 2018 at 11:32:47AM +0100, Mark Brown wrote: > On Wed, Oct 03, 2018 at 07:39:26PM -0700, Nathan Chancellor wrote: > > Clang warns when one enumerated type is implicitly converted to another. > > > > drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from > > enumeration

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-04 Thread Nathan Chancellor
On Thu, Oct 04, 2018 at 11:32:47AM +0100, Mark Brown wrote: > On Wed, Oct 03, 2018 at 07:39:26PM -0700, Nathan Chancellor wrote: > > Clang warns when one enumerated type is implicitly converted to another. > > > > drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from > > enumeration

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-04 Thread Mark Brown
On Wed, Oct 03, 2018 at 07:39:26PM -0700, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another. > > drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from > enumeration type 'enum dma_transfer_direction' to different enumeration Please

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-04 Thread Mark Brown
On Wed, Oct 03, 2018 at 07:39:26PM -0700, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another. > > drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from > enumeration type 'enum dma_transfer_direction' to different enumeration Please

[PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-03 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from enumeration type 'enum dma_transfer_direction' to different enumeration type 'enum dma_data_direction' [-Wenum-conversion] nents =

[PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

2018-10-03 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from enumeration type 'enum dma_transfer_direction' to different enumeration type 'enum dma_data_direction' [-Wenum-conversion] nents =