Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure

2020-06-02 Thread Mark Brown
On Tue, Jun 02, 2020 at 12:02:11PM +0200, Markus Elfring wrote: > > The original changelog is perfectly fine, please stop sending these. > I find this commit message improvable also according to Linux software > development documentation. Causing people to send out new versions of things for

Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure

2020-06-02 Thread Markus Elfring
> The original changelog is perfectly fine, please stop sending these. I find this commit message improvable also according to Linux software development documentation. Regards, Markus

Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure

2020-06-02 Thread Mark Brown
On Mon, Jun 01, 2020 at 11:36:37PM -0500, Navid Emamdoost wrote: > The counter is incremented via pm_runtime_get even in failure case. > To correct the counter call pm_runtime_put in case of failure, too. Someone already sent a fix for this but in any case this isn't the correct fix -

Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure

2020-06-02 Thread Mark Brown
On Tue, Jun 02, 2020 at 10:40:33AM +0200, Markus Elfring wrote: > > The counter is incremented via pm_runtime_get even in failure case. > > To correct the counter call pm_runtime_put in case of failure, too. > > How do you think about a wording variant like the following? > >Change

Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure

2020-06-02 Thread Markus Elfring
> The counter is incremented via pm_runtime_get even in failure case. > To correct the counter call pm_runtime_put in case of failure, too. How do you think about a wording variant like the following? Change description: The PM runtime reference counter is generally incremented by a call

[PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure

2020-06-01 Thread Navid Emamdoost
The counter is incremented via pm_runtime_get even in failure case. To correct the counter call pm_runtime_put in case of failure, too. Signed-off-by: Navid Emamdoost --- drivers/spi/spi-ti-qspi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-ti-qspi.c