Re: [PATCH] spi-bfin: Add missing gpio.h include

2014-04-24 Thread Mark Brown
On Thu, Apr 24, 2014 at 08:34:32AM -0400, Steven Rostedt wrote: > It's just annoying when my tests break on something that I'm not > testing ;-) With something like this clearly you are testing it, even if you didn't mean to! signature.asc Description: Digital signature

Re: [PATCH] spi-bfin: Add missing gpio.h include

2014-04-24 Thread Steven Rostedt
On Thu, 24 Apr 2014 12:33:46 +0100 Mark Brown wrote: > On Thu, Apr 24, 2014 at 11:33:29AM +0100, Mark Brown wrote: > > On Wed, Apr 23, 2014 at 10:40:35PM -0400, Steven Rostedt wrote: > > > Running my ktest.pl tests on all the archs, I stumbled over this for > > > 3.15-rc2: > > > > Applied, thank

Re: [PATCH] spi-bfin: Add missing gpio.h include

2014-04-24 Thread Mark Brown
On Thu, Apr 24, 2014 at 11:33:29AM +0100, Mark Brown wrote: > On Wed, Apr 23, 2014 at 10:40:35PM -0400, Steven Rostedt wrote: > > Running my ktest.pl tests on all the archs, I stumbled over this for > > 3.15-rc2: > > Applied, thanks. Actually not - I already have a fix for this in -next (on a sli

Re: [PATCH] spi-bfin: Add missing gpio.h include

2014-04-24 Thread Mark Brown
On Wed, Apr 23, 2014 at 10:40:35PM -0400, Steven Rostedt wrote: > Running my ktest.pl tests on all the archs, I stumbled over this for > 3.15-rc2: Applied, thanks. signature.asc Description: Digital signature

[PATCH] spi-bfin: Add missing gpio.h include

2014-04-23 Thread Steven Rostedt
Running my ktest.pl tests on all the archs, I stumbled over this for 3.15-rc2: drivers/spi/spi-bfin5xx.c: In function 'bfin_spi_cs_active': drivers/spi/spi-bfin5xx.c:169:3: error: implicit declaration of function 'gpio_set_value' [-Werror=implicit-function-declaration] drivers/spi/spi-bfin5xx.c: