Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, OGAWA Hirofumi wrote: > Jens Axboe <[EMAIL PROTECTED]> writes: > > >> nfsd_vfs_read() path. > >> > >> nfsd_vfs_read() > >> splice_direct_to_actor() > >> while(len) { > >> do_splice_to() [update sd->pos] > >> ->

Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-16 Thread OGAWA Hirofumi
Jens Axboe <[EMAIL PROTECTED]> writes: >> nfsd_vfs_read() path. >> >> nfsd_vfs_read() >> splice_direct_to_actor() >> while(len) { >> do_splice_to() [update sd->pos] >> -> generic_file_splice_read() [read from sd->pos] >>

Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, OGAWA Hirofumi wrote: > Jens Axboe <[EMAIL PROTECTED]> writes: > > > On Mon, Jul 16 2007, OGAWA Hirofumi wrote: > >> Hi, > >> > >> I've noticed the nfsd read corruption by recent change. And this patch > >> fixes the problem for me, is this right fix? > >> -- > >> OGAWA

Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-16 Thread OGAWA Hirofumi
Jens Axboe <[EMAIL PROTECTED]> writes: > On Mon, Jul 16 2007, OGAWA Hirofumi wrote: >> Hi, >> >> I've noticed the nfsd read corruption by recent change. And this patch >> fixes the problem for me, is this right fix? >> -- >> OGAWA Hirofumi <[EMAIL PROTECTED]> >> >> >> __splice_from_pipe() is

Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, OGAWA Hirofumi wrote: > Hi, > > I've noticed the nfsd read corruption by recent change. And this patch > fixes the problem for me, is this right fix? > -- > OGAWA Hirofumi <[EMAIL PROTECTED]> > > > __splice_from_pipe() is updating the sd->pos for the actor, but those >

Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, OGAWA Hirofumi wrote: Hi, I've noticed the nfsd read corruption by recent change. And this patch fixes the problem for me, is this right fix? -- OGAWA Hirofumi [EMAIL PROTECTED] __splice_from_pipe() is updating the sd-pos for the actor, but those functions are

Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-16 Thread OGAWA Hirofumi
Jens Axboe [EMAIL PROTECTED] writes: On Mon, Jul 16 2007, OGAWA Hirofumi wrote: Hi, I've noticed the nfsd read corruption by recent change. And this patch fixes the problem for me, is this right fix? -- OGAWA Hirofumi [EMAIL PROTECTED] __splice_from_pipe() is updating the sd-pos for

Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, OGAWA Hirofumi wrote: Jens Axboe [EMAIL PROTECTED] writes: On Mon, Jul 16 2007, OGAWA Hirofumi wrote: Hi, I've noticed the nfsd read corruption by recent change. And this patch fixes the problem for me, is this right fix? -- OGAWA Hirofumi [EMAIL PROTECTED]

Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-16 Thread OGAWA Hirofumi
Jens Axboe [EMAIL PROTECTED] writes: nfsd_vfs_read() path. nfsd_vfs_read() splice_direct_to_actor() while(len) { do_splice_to() [update sd-pos] - generic_file_splice_read() [read from sd-pos]

Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-16 Thread Jens Axboe
On Mon, Jul 16 2007, OGAWA Hirofumi wrote: Jens Axboe [EMAIL PROTECTED] writes: nfsd_vfs_read() path. nfsd_vfs_read() splice_direct_to_actor() while(len) { do_splice_to() [update sd-pos] - generic_file_splice_read()

[PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-15 Thread OGAWA Hirofumi
Hi, I've noticed the nfsd read corruption by recent change. And this patch fixes the problem for me, is this right fix? -- OGAWA Hirofumi <[EMAIL PROTECTED]> __splice_from_pipe() is updating the sd->pos for the actor, but those functions are passing the sd of reader side directory. So, splice

[PATCH] splice: fix wrong __splice_from_pipe() usage

2007-07-15 Thread OGAWA Hirofumi
Hi, I've noticed the nfsd read corruption by recent change. And this patch fixes the problem for me, is this right fix? -- OGAWA Hirofumi [EMAIL PROTECTED] __splice_from_pipe() is updating the sd-pos for the actor, but those functions are passing the sd of reader side directory. So, splice