Re: [PATCH] spmi: pmic_arb: add support for hw version 2

2015-01-24 Thread Stanimir Varbanov
Hi Gilad, >> /* Interrupt Controller */ >> #define SPMI_PIC_OWNER_ACC_STATUS(M, N) (0x + ((32 * (M)) + (4 * >> (N > > It looks like these macros would change too, but nothing has been done > here. Interrupts haven't been tested? Stephen is right, the irq related operations are n

Re: [PATCH] spmi: pmic_arb: add support for hw version 2

2015-01-24 Thread Stanimir Varbanov
Hi Gilad, >> >>> -/* Non-data command */ >>> -static int pmic_arb_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid) >>> +static int >>> +pmic_arb_non_data_cmd_v1(struct spmi_controller *ctrl, u8 opc, u8 sid) >>> { >>> struct spmi_pmic_arb_dev *pmic_arb = >>> spmi_controller_get_drvdata

Re: [PATCH] spmi: pmic_arb: add support for hw version 2

2015-01-23 Thread Gilad Avidov
On 1/23/2015 10:03 AM, Stanimir Varbanov wrote: Hi Gilad, On 01/20/2015 03:10 AM, Gilad Avidov wrote: Qualcomm PMIC Arbiter version-2 changes from version-1 are: - Some diffrent register offsets. - New channel register space, one per PMIC peripheral (ppid). All tx tarffic uses these channel

Re: [PATCH] spmi: pmic_arb: add support for hw version 2

2015-01-23 Thread Gilad Avidov
Hi Stephen, On 1/21/2015 11:56 AM, Stephen Boyd wrote: On 01/19/2015 05:10 PM, Gilad Avidov wrote: Qualcomm PMIC Arbiter version-2 changes from version-1 are: - Some diffrent register offsets. s/diffrent/different/ will correct the spelling. Thank you for pointing them out. - New channe

Re: [PATCH] spmi: pmic_arb: add support for hw version 2

2015-01-23 Thread Gilad Avidov
Hi Ivan, On 1/21/2015 7:32 AM, Ivan T. Ivanov wrote: Hi Gilad, Just few comments. On Mon, 2015-01-19 at 18:10 -0700, Gilad Avidov wrote: Qualcomm PMIC Arbiter version-2 changes from version-1 are: - Some diffrent register offsets. - New channel register space, one per PMIC peripheral (ppid).

Re: [PATCH] spmi: pmic_arb: add support for hw version 2

2015-01-23 Thread Stanimir Varbanov
Hi Gilad, On 01/20/2015 03:10 AM, Gilad Avidov wrote: > Qualcomm PMIC Arbiter version-2 changes from version-1 are: > > - Some diffrent register offsets. > - New channel register space, one per PMIC peripheral (ppid). > All tx tarffic uses these channels. > - New observer register space. All rx

Re: [PATCH] spmi: pmic_arb: add support for hw version 2

2015-01-21 Thread Stephen Boyd
On 01/19/2015 05:10 PM, Gilad Avidov wrote: > Qualcomm PMIC Arbiter version-2 changes from version-1 are: > > - Some diffrent register offsets. s/diffrent/different/ > - New channel register space, one per PMIC peripheral (ppid). > All tx tarffic uses these channels. s/tarffic/traffic/ > -

Re: [PATCH] spmi: pmic_arb: add support for hw version 2

2015-01-21 Thread Ivan T. Ivanov
Hi Gilad, Just few comments. On Mon, 2015-01-19 at 18:10 -0700, Gilad Avidov wrote: > Qualcomm PMIC Arbiter version-2 changes from version-1 are: > > - Some diffrent register offsets. > - New channel register space, one per PMIC peripheral (ppid). > All tx tarffic uses these channels. > - New

[PATCH] spmi: pmic_arb: add support for hw version 2

2015-01-19 Thread Gilad Avidov
Qualcomm PMIC Arbiter version-2 changes from version-1 are: - Some diffrent register offsets. - New channel register space, one per PMIC peripheral (ppid). All tx tarffic uses these channels. - New observer register space. All rx trafic uses this space. - Diffrent command format for spmi command