Re: [PATCH] spmi: regmap: enable userspace writes

2016-10-06 Thread kgunda
On 2016-10-04 02:33, Stephen Boyd wrote: On 09/30, kgu...@codeaurora.org wrote: On 2016-09-29 23:30, Mark Brown wrote: >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: > >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS >>+#define REGMAP_ALLOW_WRITE_DEBUGFS > >This is completely inappropriate

Re: [PATCH] spmi: regmap: enable userspace writes

2016-10-06 Thread kgunda
On 2016-10-04 02:33, Stephen Boyd wrote: On 09/30, kgu...@codeaurora.org wrote: On 2016-09-29 23:30, Mark Brown wrote: >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: > >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS >>+#define REGMAP_ALLOW_WRITE_DEBUGFS > >This is completely inappropriate

Re: [PATCH] spmi: regmap: enable userspace writes

2016-10-03 Thread Stephen Boyd
On 09/30, kgu...@codeaurora.org wrote: > On 2016-09-29 23:30, Mark Brown wrote: > >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: > > > >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS > >>+#define REGMAP_ALLOW_WRITE_DEBUGFS > > > >This is completely inappropriate for upstream, if you need to do

Re: [PATCH] spmi: regmap: enable userspace writes

2016-10-03 Thread Stephen Boyd
On 09/30, kgu...@codeaurora.org wrote: > On 2016-09-29 23:30, Mark Brown wrote: > >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: > > > >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS > >>+#define REGMAP_ALLOW_WRITE_DEBUGFS > > > >This is completely inappropriate for upstream, if you need to do

Re: [PATCH] spmi: regmap: enable userspace writes

2016-09-29 Thread kgunda
On 2016-09-29 23:30, Mark Brown wrote: On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: -#undef REGMAP_ALLOW_WRITE_DEBUGFS +#define REGMAP_ALLOW_WRITE_DEBUGFS This is completely inappropriate for upstream, if you need to do debugging on your platform you can enable this locally

Re: [PATCH] spmi: regmap: enable userspace writes

2016-09-29 Thread kgunda
On 2016-09-29 23:30, Mark Brown wrote: On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: -#undef REGMAP_ALLOW_WRITE_DEBUGFS +#define REGMAP_ALLOW_WRITE_DEBUGFS This is completely inappropriate for upstream, if you need to do debugging on your platform you can enable this locally

Re: [PATCH] spmi: regmap: enable userspace writes

2016-09-29 Thread Mark Brown
On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: > -#undef REGMAP_ALLOW_WRITE_DEBUGFS > +#define REGMAP_ALLOW_WRITE_DEBUGFS This is completely inappropriate for upstream, if you need to do debugging on your platform you can enable this locally but enabling random writes from

Re: [PATCH] spmi: regmap: enable userspace writes

2016-09-29 Thread Mark Brown
On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: > -#undef REGMAP_ALLOW_WRITE_DEBUGFS > +#define REGMAP_ALLOW_WRITE_DEBUGFS This is completely inappropriate for upstream, if you need to do debugging on your platform you can enable this locally but enabling random writes from

[PATCH] spmi: regmap: enable userspace writes

2016-09-29 Thread Kiran Gunda
Being able to write to spmi registers via userspace is required for quick debug and development. Enable it. The regmap framework uses dev_name to create debugfs dir names. So update the spmi devices to have proper names. Signed-off-by: Kiran Gunda ---

[PATCH] spmi: regmap: enable userspace writes

2016-09-29 Thread Kiran Gunda
Being able to write to spmi registers via userspace is required for quick debug and development. Enable it. The regmap framework uses dev_name to create debugfs dir names. So update the spmi devices to have proper names. Signed-off-by: Kiran Gunda --- drivers/base/regmap/regmap-debugfs.c | 2