Re: [PATCH] staging/android: add flags member to sync ioctl structs

2016-03-11 Thread Greg Kroah-Hartman
On Fri, Mar 04, 2016 at 05:40:29PM +0100, Daniel Vetter wrote: > On Thu, Mar 03, 2016 at 08:17:14AM -0800, Greg Kroah-Hartman wrote: > > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Play safe and add flags member to all structs. So we do

Re: [PATCH] staging/android: add flags member to sync ioctl structs

2016-03-05 Thread Emil Velikov
Hi Greg, Allow me to chip in as well. On 3 March 2016 at 16:17, Greg Kroah-Hartman wrote: > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Play safe and add flags member to all structs. So we don't need to >> break API or create new IOCTL in the

Re: [PATCH] staging/android: add flags member to sync ioctl structs

2016-03-04 Thread Daniel Vetter
On Thu, Mar 03, 2016 at 08:17:14AM -0800, Greg Kroah-Hartman wrote: > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Play safe and add flags member to all structs. So we don't need to > > break API or create new IOCTL in the future if new featur

Re: [PATCH] staging/android: add flags member to sync ioctl structs

2016-03-03 Thread Rob Clark
On Thu, Mar 3, 2016 at 3:54 PM, Rob Clark wrote: > On Thu, Mar 3, 2016 at 11:17 AM, Greg Kroah-Hartman > wrote: >> On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> Play safe and add flags member to all structs. So we don't need to >>> break API o

Re: [PATCH] staging/android: add flags member to sync ioctl structs

2016-03-03 Thread Rob Clark
On Thu, Mar 3, 2016 at 11:17 AM, Greg Kroah-Hartman wrote: > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Play safe and add flags member to all structs. So we don't need to >> break API or create new IOCTL in the future if new features that requi

Re: [PATCH] staging/android: add flags member to sync ioctl structs

2016-03-03 Thread Ville Syrjälä
On Thu, Mar 03, 2016 at 08:17:14AM -0800, Greg Kroah-Hartman wrote: > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Play safe and add flags member to all structs. So we don't need to > > break API or create new IOCTL in the future if new featur

Re: [PATCH] staging/android: add flags member to sync ioctl structs

2016-03-03 Thread Gustavo Padovan
2016-03-03 Gustavo Padovan : > Hi Greg, > > 2016-03-03 Greg Kroah-Hartman : > > > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Play safe and add flags member to all structs. So we don't need to > > > break API or create new IOCTL in t

Re: [PATCH] staging/android: add flags member to sync ioctl structs

2016-03-03 Thread Gustavo Padovan
Hi Greg, 2016-03-03 Greg Kroah-Hartman : > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Play safe and add flags member to all structs. So we don't need to > > break API or create new IOCTL in the future if new features that requires > > flag

Re: [PATCH] staging/android: add flags member to sync ioctl structs

2016-03-03 Thread Greg Kroah-Hartman
On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > > v2: check if flags are valid (zero, in t

[PATCH] staging/android: add flags member to sync ioctl structs

2016-03-03 Thread Gustavo Padovan
From: Gustavo Padovan Play safe and add flags member to all structs. So we don't need to break API or create new IOCTL in the future if new features that requires flags arises. v2: check if flags are valid (zero, in this case) v3: return -EINVAL if flags are not zero'ed v4: add padding for 64-

[PATCH] staging/android: add flags member to sync ioctl structs

2016-03-02 Thread Gustavo Padovan
From: Gustavo Padovan Play safe and add flags member to all structs. So we don't need to break API or create new IOCTL in the future if new features that requires flags arises. v2: check if flags are valid (zero, in this case) v3: return -EINVAL if flags are not zero'ed v4: add padding for 64-