Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning

2020-08-31 Thread Mauro Carvalho Chehab
Em Mon, 31 Aug 2020 16:30:12 +0300 Cengiz Can escreveu: > commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from > Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments > with 'fallthrough' pseudo-keyword. > > However, in one of the switch-case statements,

Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning

2020-08-31 Thread Dan Carpenter
Really I think this function is pretty buggy. It shouldn't be falling through at all... I reported it a couple days back so it's possible that someone is working on a fix already. regards, dan carpenter

Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning

2020-08-31 Thread Dan Carpenter
On Mon, Aug 31, 2020 at 04:30:12PM +0300, Cengiz Can wrote: > commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from > Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments > with 'fallthrough' pseudo-keyword. > > However, in one of the switch-case statements,

[PATCH] staging: atomisp: Fix fallthrough keyword warning

2020-08-31 Thread Cengiz Can
commit df561f6688fe ("treewide: Use fallthrough pseudo-keyword") from Gustavo A. R. Silva replaced and standardized /* fallthrough */ comments with 'fallthrough' pseudo-keyword. However, in one of the switch-case statements, Coverity Static Analyzer throws a warning that 'fallthrough' is