On Fri, 2017-02-17 at 13:39 -0500, Nathan Howard wrote:
> The following coding style issues (as per checkpatch.pl) were resolved.
What Greg said is true, and the volatile conversion
especially needs to be verified.
> diff --git a/drivers/staging/bcm2835-audio/bcm2835.h
> b/drivers/staging/bcm283
On Fri, Feb 17, 2017 at 01:39:07PM -0500, Nathan Howard wrote:
> The following coding style issues (as per checkpatch.pl) were resolved.
>
> WARNING: Block comments use * on subsequent lines
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ...
> WARNING: Missing a blank line after dec
The following coding style issues (as per checkpatch.pl) were resolved.
WARNING: Block comments use * on subsequent lines
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ...
WARNING: Missing a blank line after declarations
WARNING: Use of volatile is usually wrong:...
WARNING: line ove
On Thu, Feb 16, 2017 at 06:12:58PM -0500, Nathan Howard wrote:
> Fix various coding style issues as per checkpatch.pl.
You need to be very specific as to exactly what you are fixing here.
And please only do one type of thing per patch.
Please fix up and resend.
thanks,
greg k-h
Fix various coding style issues as per checkpatch.pl.
Signed-off-by: Nathan Howard
---
drivers/staging/bcm2835-audio/bcm2835.h | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.h
b/drivers/staging/bcm2835-
5 matches
Mail list logo