Re: [PATCH] staging: board: drop refcount in success case

2018-06-19 Thread Nicholas Mc Guire
On Tue, Jun 19, 2018 at 09:51:44AM +0200, Geert Uytterhoeven wrote: > On Tue, Jun 19, 2018 at 9:37 AM Dan Carpenter > wrote: > > On Mon, Jun 18, 2018 at 08:53:19PM +0200, Nicholas Mc Guire wrote: > > > The call to of_find_compatible_node() returns irqc_node with refcount > > > incremented thus i

Re: [PATCH] staging: board: drop refcount in success case

2018-06-19 Thread Geert Uytterhoeven
On Tue, Jun 19, 2018 at 9:37 AM Dan Carpenter wrote: > On Mon, Jun 18, 2018 at 08:53:19PM +0200, Nicholas Mc Guire wrote: > > The call to of_find_compatible_node() returns irqc_node with refcount > > incremented thus it must be explicitly decremented here after it was > > checked for non-NULL. >

Re: [PATCH] staging: board: drop refcount in success case

2018-06-19 Thread Dan Carpenter
On Mon, Jun 18, 2018 at 08:53:19PM +0200, Nicholas Mc Guire wrote: > The call to of_find_compatible_node() returns irqc_node with refcount > incremented thus it must be explicitly decremented here after it was > checked for non-NULL. > > Signed-off-by: Nicholas Mc Guire > Fixes: commit 72ee8626e

[PATCH] staging: board: drop refcount in success case

2018-06-18 Thread Nicholas Mc Guire
The call to of_find_compatible_node() returns irqc_node with refcount incremented thus it must be explicitly decremented here after it was checked for non-NULL. Signed-off-by: Nicholas Mc Guire Fixes: commit 72ee8626eeb1 ("staging: board: Add support for translating hwirq to virq numbers") ---