>> @@ -838,6 +834,10 @@ static int usbduxfast_ai_insn_read(struct comedi_device
>> *dev,
>> mutex_unlock(>mut);
>> return insn->n;
>
> Minor niggle: You could also remove that call to mutex_unlock() by replacing
> the above three lines with:
>
> ret = insn->n;
>
> which will
>> @@ -838,6 +834,10 @@ static int usbduxfast_ai_insn_read(struct comedi_device
>> *dev,
>> mutex_unlock(>mut);
>> return insn->n;
>
> Minor niggle: You could also remove that call to mutex_unlock() by replacing
> the above three lines with:
>
> ret = insn->n;
>
> which will
On Fri, Nov 03, 2017 at 02:00:18PM +, Ian Abbott wrote:
> On 02/11/17 19:40, SF Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Thu, 2 Nov 2017 20:30:31 +0100
> >
> > * Add a jump target so that a call of the function "mutex_unlock" is stored
> >
On Fri, Nov 03, 2017 at 02:00:18PM +, Ian Abbott wrote:
> On 02/11/17 19:40, SF Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Thu, 2 Nov 2017 20:30:31 +0100
> >
> > * Add a jump target so that a call of the function "mutex_unlock" is stored
> >only twice in this function
On 02/11/17 19:40, SF Markus Elfring wrote:
From: Markus Elfring
Date: Thu, 2 Nov 2017 20:30:31 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace five calls by goto
On 02/11/17 19:40, SF Markus Elfring wrote:
From: Markus Elfring
Date: Thu, 2 Nov 2017 20:30:31 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace five calls by goto statements.
This issue was detected by
From: Markus Elfring
Date: Thu, 2 Nov 2017 20:30:31 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace five calls by goto statements.
This issue was detected by using the
From: Markus Elfring
Date: Thu, 2 Nov 2017 20:30:31 +0100
* Add a jump target so that a call of the function "mutex_unlock" is stored
only twice in this function implementation.
* Replace five calls by goto statements.
This issue was detected by using the Coccinelle software.
Signed-off-by:
8 matches
Mail list logo