Re: [PATCH] staging: emxx_udc: Use standard BIT() macro

2020-08-18 Thread Alex Dewar
On Tue, Aug 18, 2020 at 07:29:02AM -0700, Randy Dunlap wrote: > On 8/18/20 6:49 AM, Alex Dewar wrote: > > Currently emxx_udc.h defines bit values using local macros. Use the > > standard one instead. > > > > Also, combine bit values with bitwise-or rather than addition, as > > suggested by

Re: [PATCH] staging: emxx_udc: Use standard BIT() macro

2020-08-18 Thread Randy Dunlap
On 8/18/20 6:49 AM, Alex Dewar wrote: > Currently emxx_udc.h defines bit values using local macros. Use the > standard one instead. > > Also, combine bit values with bitwise-or rather than addition, as > suggested by Coccinelle. > > Signed-off-by: Alex Dewar Hi, Does this build? Just

[PATCH] staging: emxx_udc: Use standard BIT() macro

2020-08-18 Thread Alex Dewar
Currently emxx_udc.h defines bit values using local macros. Use the standard one instead. Also, combine bit values with bitwise-or rather than addition, as suggested by Coccinelle. Signed-off-by: Alex Dewar --- drivers/staging/emxx_udc/emxx_udc.h | 456 +--- 1 file