Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-16 Thread Joe Perches
On Wed, 2014-07-16 at 15:57 -0700, Greg KH wrote: > On Wed, Jul 16, 2014 at 03:46:09PM -0700, Joe Perches wrote: > > On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote: > > > On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote: > > [] > > > > Ok, I agree on the ifdef stuff. My question wa

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-16 Thread Greg KH
On Wed, Jul 16, 2014 at 03:46:09PM -0700, Joe Perches wrote: > On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote: > > On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote: > [] > > > Ok, I agree on the ifdef stuff. My question was regarding your > > > suggestion above to replace print_hex

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-16 Thread Joe Perches
On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote: > On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote: [] > > Ok, I agree on the ifdef stuff. My question was regarding your > > suggestion above to replace print_hex_debug() with dev_dbg() > > You want the device name/id/label to show

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-16 Thread Greg KH
On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote: > On 07/16/2014 09:50 PM, Greg KH wrote: > > On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote: > >> On 07/09/2014 07:51 PM, Greg KH wrote: > diff --git a/drivers/staging/gdm72xx/gdm_sdio.c > b/drivers/staging

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-16 Thread Michalis Pappas
On 07/16/2014 09:50 PM, Greg KH wrote: > On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote: >> On 07/09/2014 07:51 PM, Greg KH wrote: diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c index 9d2de6f..914fd75 100644 --- a/drivers/s

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-16 Thread Greg KH
On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote: > On 07/09/2014 07:51 PM, Greg KH wrote: > >> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c > >> b/drivers/staging/gdm72xx/gdm_sdio.c > >> index 9d2de6f..914fd75 100644 > >> --- a/drivers/staging/gdm72xx/gdm_sdio.c > >> +++ b/drive

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-16 Thread Michalis Pappas
On 07/09/2014 07:51 PM, Greg KH wrote: >> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c >> b/drivers/staging/gdm72xx/gdm_sdio.c >> index 9d2de6f..914fd75 100644 >> --- a/drivers/staging/gdm72xx/gdm_sdio.c >> +++ b/drivers/staging/gdm72xx/gdm_sdio.c >> @@ -280,9 +280,11 @@ static void send_sdu(st

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-09 Thread Greg KH
On Wed, Jul 09, 2014 at 08:52:07PM +0100, Michalis Pappas wrote: > On 07/09/2014 07:51 PM, Greg KH wrote: > > On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote: > >> Signed-off-by: Michalis Pappas > >> --- > >> drivers/staging/gdm72xx/gdm_qos.c | 2 ++ > >> drivers/staging/gdm72xx

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-09 Thread Michalis Pappas
On 07/09/2014 07:51 PM, Greg KH wrote: > On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote: >> Signed-off-by: Michalis Pappas >> --- >> drivers/staging/gdm72xx/gdm_qos.c | 2 ++ >> drivers/staging/gdm72xx/gdm_sdio.c | 7 +++ >> drivers/staging/gdm72xx/gdm_usb.c | 7 +++

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-09 Thread Greg KH
On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote: > Signed-off-by: Michalis Pappas > --- > drivers/staging/gdm72xx/gdm_qos.c | 2 ++ > drivers/staging/gdm72xx/gdm_sdio.c | 7 +++ > drivers/staging/gdm72xx/gdm_usb.c | 7 +++ > drivers/staging/gdm72xx/gdm_wimax.c | 6 +++

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-03 Thread Michalis Pappas
On 07/01/2014 07:08 PM, Ben Chan wrote: > > > > On Tue, Jul 1, 2014 at 9:40 AM, Michalis Pappas > wrote: > > On 07/01/2014 04:30 PM, Ben Chan wrote: > > > > > > > > On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas > mailto:mpap...@fastmail.fm>

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-01 Thread Michalis Pappas
On 07/01/2014 04:30 PM, Ben Chan wrote: > > > > On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas > wrote: > > Signed-off-by: Michalis Pappas > > --- > drivers/staging/gdm72xx/gdm_qos.c | 2 ++ > drivers/staging/gdm7

[PATCH] staging: gdm72xx: conditionally compile debug code

2014-07-01 Thread Michalis Pappas
Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 2 ++ drivers/staging/gdm72xx/gdm_sdio.c | 7 +++ drivers/staging/gdm72xx/gdm_usb.c | 7 +++ drivers/staging/gdm72xx/gdm_wimax.c | 6 ++ drivers/staging/gdm72xx/gdm_wimax.h | 2 ++ 5 files changed, 24 insertio