[PATCH] staging: greybus: Parenthesis alignment

2018-11-25 Thread Cristian Sicilia
Some parameters are aligned with parentheses. Some parentheses was opened at end of line. Signed-off-by: Cristian Sicilia --- Changes on v2: * There was some function that was splitted in two line, as suggested, is better to keep it in one line.

[PATCH] staging: greybus: Parenthesis alignment

2018-11-25 Thread Cristian Sicilia
Some parameters are aligned with parentheses. Some parentheses was opened at end of line. Signed-off-by: Cristian Sicilia --- Changes on v2: * There was some function that was splitted in two line, as suggested, is better to keep it in one line.

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-21 Thread Joe Perches
On Wed, 2018-11-21 at 15:58 +1100, NeilBrown wrote: > On Sun, Nov 18 2018, Joe Perches wrote: > > > On Sun, 2018-11-18 at 20:28 +0100, Cristian Sicilia wrote: > > > Some parameters are aligned with parentheses. > > > Some parentheses are opened at end of line. > > > > Given the very long

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-21 Thread Joe Perches
On Wed, 2018-11-21 at 15:58 +1100, NeilBrown wrote: > On Sun, Nov 18 2018, Joe Perches wrote: > > > On Sun, 2018-11-18 at 20:28 +0100, Cristian Sicilia wrote: > > > Some parameters are aligned with parentheses. > > > Some parentheses are opened at end of line. > > > > Given the very long

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-20 Thread Greg Kroah-Hartman
On Tue, Nov 20, 2018 at 11:42:05PM +0100, Cristian Sicilia wrote: > Thanks for note > > Can make sense do the patch for function that stay in the line but is not > aligned, or is better doesn't change anything? > Like this: > > static ssize_t gb_camera_debugfs_capabilities(struct gb_camera

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-20 Thread Greg Kroah-Hartman
On Tue, Nov 20, 2018 at 11:42:05PM +0100, Cristian Sicilia wrote: > Thanks for note > > Can make sense do the patch for function that stay in the line but is not > aligned, or is better doesn't change anything? > Like this: > > static ssize_t gb_camera_debugfs_capabilities(struct gb_camera

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-20 Thread NeilBrown
On Sun, Nov 18 2018, Joe Perches wrote: > On Sun, 2018-11-18 at 20:28 +0100, Cristian Sicilia wrote: >> Some parameters are aligned with parentheses. >> Some parentheses are opened at end of line. > > Given the very long identifier lengths, I wouldn't > consider many of these appropriate. > > 80

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-20 Thread NeilBrown
On Sun, Nov 18 2018, Joe Perches wrote: > On Sun, 2018-11-18 at 20:28 +0100, Cristian Sicilia wrote: >> Some parameters are aligned with parentheses. >> Some parentheses are opened at end of line. > > Given the very long identifier lengths, I wouldn't > consider many of these appropriate. > > 80

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-20 Thread Greg Kroah-Hartman
On Sun, Nov 18, 2018 at 08:28:07PM +0100, Cristian Sicilia wrote: > Some parameters are aligned with parentheses. > Some parentheses are opened at end of line. > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/greybus/arche-platform.c | 6 +- >

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-20 Thread Greg Kroah-Hartman
On Sun, Nov 18, 2018 at 08:28:07PM +0100, Cristian Sicilia wrote: > Some parameters are aligned with parentheses. > Some parentheses are opened at end of line. > > Signed-off-by: Cristian Sicilia > --- > drivers/staging/greybus/arche-platform.c | 6 +- >

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-18 Thread Joe Perches
On Sun, 2018-11-18 at 20:28 +0100, Cristian Sicilia wrote: > Some parameters are aligned with parentheses. > Some parentheses are opened at end of line. Given the very long identifier lengths, I wouldn't consider many of these appropriate. 80 column line lengths and long identifiers don't play

Re: [PATCH] staging: greybus: Parenthesis alignment

2018-11-18 Thread Joe Perches
On Sun, 2018-11-18 at 20:28 +0100, Cristian Sicilia wrote: > Some parameters are aligned with parentheses. > Some parentheses are opened at end of line. Given the very long identifier lengths, I wouldn't consider many of these appropriate. 80 column line lengths and long identifiers don't play

[PATCH] staging: greybus: Parenthesis alignment

2018-11-18 Thread Cristian Sicilia
Some parameters are aligned with parentheses. Some parentheses are opened at end of line. Signed-off-by: Cristian Sicilia --- drivers/staging/greybus/arche-platform.c | 6 +- drivers/staging/greybus/audio_codec.c | 8 +- drivers/staging/greybus/audio_manager_module.c | 55

[PATCH] staging: greybus: Parenthesis alignment

2018-11-18 Thread Cristian Sicilia
Some parameters are aligned with parentheses. Some parentheses are opened at end of line. Signed-off-by: Cristian Sicilia --- drivers/staging/greybus/arche-platform.c | 6 +- drivers/staging/greybus/audio_codec.c | 8 +- drivers/staging/greybus/audio_manager_module.c | 55