Re: [PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c

On Mon, May 08, 2017 at 01:38:47AM -0400, harinath Nampally wrote: > Hi Greg, > > Thank you so much for your time to review.  > Sure I will break up into multiple patches and create patch series. > But I wonder 'one thing' per patch means one kind of warnings per patch? Yes it does. > For exampl

Re: [PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c

On Mon, May 08, 2017 at 12:16:17AM -0400, Harinath Nampally wrote: > All below warnings are found and fixed by checkpatch.pl: > CHECK: struct mutex definition without comment > CHECK: Alignment should match open parenthesis > WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. You

[PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c

All below warnings are found and fixed by checkpatch.pl: CHECK: struct mutex definition without comment CHECK: Alignment should match open parenthesis WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Below errors are false positives: ade7753.c:382: ERROR: Use 4 digit octal (077