Re: [PATCH] staging: kpc2000: Use memset to initialize resources

2019-04-30 Thread Nick Desaulniers
On Tue, Apr 30, 2019 at 2:12 AM Dan Carpenter wrote: > Also it was risky from a process perspective to delete the stray tab > from the next line because some one could have argued that it was > unrelated or that the whole line should be removed instead. You would > have had to redo the patch for

Re: [PATCH] staging: kpc2000: Use memset to initialize resources

2019-04-30 Thread Dan Carpenter
On Wed, Apr 24, 2019 at 11:57:43AM -0700, Nathan Chancellor wrote: > diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c > b/drivers/staging/kpc2000/kpc2000/cell_probe.c > index ad2cc0a3bfa1..13f544f3c0b9 100644 > --- a/drivers/staging/kpc2000/kpc2000/cell_probe.c > +++ b/drivers/staging/kpc

Re: [PATCH] staging: kpc2000: Use memset to initialize resources

2019-04-24 Thread Nick Desaulniers
On Wed, Apr 24, 2019 at 11:58 AM Nathan Chancellor wrote: > > Clang warns: > > drivers/staging/kpc2000/kpc2000/cell_probe.c:96:38: warning: suggest > braces around initialization of subobject [-Wmissing-braces] > struct resource resources[2] = {0}; > ^ >

[PATCH] staging: kpc2000: Use memset to initialize resources

2019-04-24 Thread Nathan Chancellor
Clang warns: drivers/staging/kpc2000/kpc2000/cell_probe.c:96:38: warning: suggest braces around initialization of subobject [-Wmissing-braces] struct resource resources[2] = {0}; ^ {} drivers/staging/kpc2000/kpc2000/cel