Re: [PATCH] staging: ks7010: clean up code

2017-03-04 Thread Ernestas Kulik
On Fri, 2017-03-03 at 23:24-0800, Joe Perches wrote: > > More stuff the changelog doesn't show :( > > On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > > This fixes type warnings generated by sparse, replaces instances of > > ntohs() with be16_to_cpu() and removes unused fields in

Re: [PATCH] staging: ks7010: clean up code

2017-03-04 Thread Ernestas Kulik
On Fri, 2017-03-03 at 23:24-0800, Joe Perches wrote: > > More stuff the changelog doesn't show :( > > On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > > This fixes type warnings generated by sparse, replaces instances of > > ntohs() with be16_to_cpu() and removes unused fields in

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Joe Perches
On Sat, 2017-03-04 at 08:49 +0200, Ernestas Kulik wrote: > On Fri, 2017-03-03 at 22:37-0800, Joe Perches wrote: > > > > struct hostif_hdr.event is declared at uint16_t > > and not as __le16 so I believe this is incorrect > > and actually introduces a sparse error. > > Sure, but I change that in

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Joe Perches
On Sat, 2017-03-04 at 08:49 +0200, Ernestas Kulik wrote: > On Fri, 2017-03-03 at 22:37-0800, Joe Perches wrote: > > > > struct hostif_hdr.event is declared at uint16_t > > and not as __le16 so I believe this is incorrect > > and actually introduces a sparse error. > > Sure, but I change that in

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Ernestas Kulik
On Fri, 2017-03-03 at 22:37-0800, Joe Perches wrote: > > struct hostif_hdr.event is declared at uint16_t > and not as __le16 so I believe this is incorrect > and actually introduces a sparse error. Sure, but I change that in the patch. :) On Sat, 2017-03-04 at 08:28 +0200, Ernestas Kulik wrote:

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Ernestas Kulik
On Fri, 2017-03-03 at 22:37-0800, Joe Perches wrote: > > struct hostif_hdr.event is declared at uint16_t > and not as __le16 so I believe this is incorrect > and actually introduces a sparse error. Sure, but I change that in the patch. :) On Sat, 2017-03-04 at 08:28 +0200, Ernestas Kulik wrote:

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Joe Perches
On Sat, 2017-03-04 at 08:28 +0200, Ernestas Kulik wrote: > On Fri, 2017-03-03 at 17:23-0800, Joe Perches wrote: > > > On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > > > > > This fixes type warnings generated by sparse, replaces instances of > > > ntohs() with be16_to_cpu() and

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Joe Perches
On Sat, 2017-03-04 at 08:28 +0200, Ernestas Kulik wrote: > On Fri, 2017-03-03 at 17:23-0800, Joe Perches wrote: > > > On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > > > > > This fixes type warnings generated by sparse, replaces instances of > > > ntohs() with be16_to_cpu() and

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Ernestas Kulik
On Fri, 2017-03-03 at 17:23-0800, Joe Perches wrote: > On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > > > This fixes type warnings generated by sparse, replaces instances of > > ntohs() with be16_to_cpu() and removes unused fields in structs. > > There's no real need to convert ntohs

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Ernestas Kulik
On Fri, 2017-03-03 at 17:23-0800, Joe Perches wrote: > On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > > > This fixes type warnings generated by sparse, replaces instances of > > ntohs() with be16_to_cpu() and removes unused fields in structs. > > There's no real need to convert ntohs

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Joe Perches
On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > This fixes type warnings generated by sparse, replaces instances of > ntohs() with be16_to_cpu() and removes unused fields in structs. There's no real need to convert ntohs to be16_to_cpu > diff --git

Re: [PATCH] staging: ks7010: clean up code

2017-03-03 Thread Joe Perches
On Fri, 2017-03-03 at 22:58 +0200, Ernestas Kulik wrote: > This fixes type warnings generated by sparse, replaces instances of > ntohs() with be16_to_cpu() and removes unused fields in structs. There's no real need to convert ntohs to be16_to_cpu > diff --git

[PATCH] staging: ks7010: clean up code

2017-03-03 Thread Ernestas Kulik
This fixes type warnings generated by sparse, replaces instances of ntohs() with be16_to_cpu() and removes unused fields in structs. Signed-off-by: Ernestas Kulik --- drivers/staging/ks7010/ks7010_sdio.c | 12 ++-- drivers/staging/ks7010/ks_hostif.c | 30 +

[PATCH] staging: ks7010: clean up code

2017-03-03 Thread Ernestas Kulik
This fixes type warnings generated by sparse, replaces instances of ntohs() with be16_to_cpu() and removes unused fields in structs. Signed-off-by: Ernestas Kulik --- drivers/staging/ks7010/ks7010_sdio.c | 12 ++-- drivers/staging/ks7010/ks_hostif.c | 30 +