Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-29 Thread Heba Aamer
On Wed, Jan 28, 2015 at 05:56:07PM -0800, Joe Perches wrote: > On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote: > > This patch fixes the following checkpatch.pl warning: > > Prefer seq_puts to seq_printf > > checkpatch is pretty stupid. > Please don't just do what it says. I checked

Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-29 Thread Heba Aamer
On Wed, Jan 28, 2015 at 05:56:07PM -0800, Joe Perches wrote: On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer seq_puts to seq_printf checkpatch is pretty stupid. Please don't just do what it says. I checked checkpatch

Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-28 Thread Joe Perches
On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote: > This patch fixes the following checkpatch.pl warning: > Prefer seq_puts to seq_printf checkpatch is pretty stupid. Please don't just do what it says. Look further and see what else can be improved. > diff --git

Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-28 Thread Greg KH
On Wed, Jan 28, 2015 at 04:05:33PM +0200, Heba Aamer wrote: > This patch fixes the following checkpatch.pl warning: > Prefer seq_puts to seq_printf > > Signed-off-by: Heba Aamer > --- > drivers/staging/lustre/lustre/osc/lproc_osc.c |8 > 1 file changed, 4 insertions(+), 4

[PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl warning: Prefer seq_puts to seq_printf Signed-off-by: Heba Aamer --- drivers/staging/lustre/lustre/osc/lproc_osc.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c

[PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl warning: Prefer seq_puts to seq_printf Signed-off-by: Heba Aamer heba93aa...@gmail.com --- drivers/staging/lustre/lustre/osc/lproc_osc.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-28 Thread Joe Perches
On Wed, 2015-01-28 at 16:05 +0200, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer seq_puts to seq_printf checkpatch is pretty stupid. Please don't just do what it says. Look further and see what else can be improved. diff --git

Re: [PATCH] staging: lustre: lustre: osc: fix Prefer seq_puts to seq_printf

2015-01-28 Thread Greg KH
On Wed, Jan 28, 2015 at 04:05:33PM +0200, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer seq_puts to seq_printf Signed-off-by: Heba Aamer heba93aa...@gmail.com --- drivers/staging/lustre/lustre/osc/lproc_osc.c |8 1 file changed, 4