Re: [PATCH] staging: lustre: lustre: osc: lproc_osc.c: Fix for possible null pointer dereference

2014-12-16 Thread Dan Carpenter
On Tue, Dec 16, 2014 at 12:07:19AM +0100, Rickard Strandqvist wrote: > Hi Dan > > Quite right! Had to try it. > > Do nothing then? > But you must agree that it is still ugly and confusing code. > Yes. I agree that it's confusing. I also suspect that "obd" is never NULL but I haven't actually

Re: [PATCH] staging: lustre: lustre: osc: lproc_osc.c: Fix for possible null pointer dereference

2014-12-16 Thread Dan Carpenter
On Tue, Dec 16, 2014 at 12:07:19AM +0100, Rickard Strandqvist wrote: Hi Dan Quite right! Had to try it. Do nothing then? But you must agree that it is still ugly and confusing code. Yes. I agree that it's confusing. I also suspect that obd is never NULL but I haven't actually looked

Re: [PATCH] staging: lustre: lustre: osc: lproc_osc.c: Fix for possible null pointer dereference

2014-12-15 Thread Rickard Strandqvist
Hi Dan Quite right! Had to try it. Do nothing then? But you must agree that it is still ugly and confusing code. Kind regards Rickard Strandqvist 2014-12-15 11:25 GMT+01:00 Dan Carpenter : > On Sun, Dec 14, 2014 at 11:37:18PM +0100, Rickard Strandqvist wrote: >> There is otherwise a risk of a

Re: [PATCH] staging: lustre: lustre: osc: lproc_osc.c: Fix for possible null pointer dereference

2014-12-15 Thread Dan Carpenter
On Sun, Dec 14, 2014 at 11:37:18PM +0100, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- >

Re: [PATCH] staging: lustre: lustre: osc: lproc_osc.c: Fix for possible null pointer dereference

2014-12-15 Thread Dan Carpenter
On Sun, Dec 14, 2014 at 11:37:18PM +0100, Rickard Strandqvist wrote: There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

Re: [PATCH] staging: lustre: lustre: osc: lproc_osc.c: Fix for possible null pointer dereference

2014-12-15 Thread Rickard Strandqvist
Hi Dan Quite right! Had to try it. Do nothing then? But you must agree that it is still ugly and confusing code. Kind regards Rickard Strandqvist 2014-12-15 11:25 GMT+01:00 Dan Carpenter dan.carpen...@oracle.com: On Sun, Dec 14, 2014 at 11:37:18PM +0100, Rickard Strandqvist wrote: There is

[PATCH] staging: lustre: lustre: osc: lproc_osc.c: Fix for possible null pointer dereference

2014-12-14 Thread Rickard Strandqvist
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/osc/lproc_osc.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH] staging: lustre: lustre: osc: lproc_osc.c: Fix for possible null pointer dereference

2014-12-14 Thread Rickard Strandqvist
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/lustre/lustre/osc/lproc_osc.c |4 +++- 1 file changed, 3