Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Marcus Wolf
Hi Dan, Thanks for the hint. I don't get, what went wrong. If I take the mail from my outbox and view it, it looks nice. Seems, I really need to look for another mailtool. But for several reasons, that's not possible at the moment (slow move of 20 domains with someting arround 80 mail adresses

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Marcus Wolf
Hi Dan, Thanks for the hint. I don't get, what went wrong. If I take the mail from my outbox and view it, it looks nice. Seems, I really need to look for another mailtool. But for several reasons, that's not possible at the moment (slow move of 20 domains with someting arround 80 mail adresses

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Dan Carpenter
On Fri, Jul 28, 2017 at 04:21:05PM +0200, Marcus Wolf wrote: > Hi Arnd, > > we already have a patch for this: > [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation > from 20.07.2017 https://patchwork.kernel.org/patch/9855261/ > > Maybe I did something wrong, but my

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Dan Carpenter
On Fri, Jul 28, 2017 at 04:21:05PM +0200, Marcus Wolf wrote: > Hi Arnd, > > we already have a patch for this: > [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation > from 20.07.2017 https://patchwork.kernel.org/patch/9855261/ > > Maybe I did something wrong, but my

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Arnd Bergmann
On Fri, Jul 28, 2017 at 4:21 PM, Marcus Wolf wrote: > Hi Arnd, > > we already have a patch for this: > [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation > from 20.07.2017 > > Maybe I did something wrong, but my first solution was

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Arnd Bergmann
On Fri, Jul 28, 2017 at 4:21 PM, Marcus Wolf wrote: > Hi Arnd, > > we already have a patch for this: > [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation > from 20.07.2017 > > Maybe I did something wrong, but my first solution was exactly like your > proposal. As far as

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Marcus Wolf
Hi Arnd, we already have a patch for this: [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation from 20.07.2017 Maybe I did something wrong, but my first solution was exactly like your proposal. As far as I remeber, I wasn't able to compile it that way. Therefore I made

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Marcus Wolf
Hi Arnd, we already have a patch for this: [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation from 20.07.2017 Maybe I did something wrong, but my first solution was exactly like your proposal. As far as I remeber, I wasn't able to compile it that way. Therefore I made

[PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Arnd Bergmann
I ran into this link error on an ARM OABI build: drivers/staging/pi433/rf69.o: In function `rf69_set_frequency': rf69.c:(.text+0xc9c): undefined reference to `__udivdi3' No idea why I didn't see it with the default EABI configurations, but the right solution here seems to be to use div_u64() to

[PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Arnd Bergmann
I ran into this link error on an ARM OABI build: drivers/staging/pi433/rf69.o: In function `rf69_set_frequency': rf69.c:(.text+0xc9c): undefined reference to `__udivdi3' No idea why I didn't see it with the default EABI configurations, but the right solution here seems to be to use div_u64() to