Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Larry Finger
On 01/29/2015 01:54 PM, Aya Mahfouz wrote: On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote: On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Aya Mahfouz
On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote: > On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: > > On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: > > > On 01/28/2015 09:53 AM, Heba Aamer wrote: > > > >This patch fixes the following checkpatch.pl

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Dan Carpenter
On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: > On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: > > On 01/28/2015 09:53 AM, Heba Aamer wrote: > > >This patch fixes the following checkpatch.pl warning: > > >Prefer ether_addr_copy() over memcpy() > > >if the Ethernet

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Dan Carpenter
On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Aya Mahfouz
On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote: On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning:

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-29 Thread Larry Finger
On 01/29/2015 01:54 PM, Aya Mahfouz wrote: On Thu, Jan 29, 2015 at 02:51:57PM +0300, Dan Carpenter wrote: On Wed, Jan 28, 2015 at 11:30:11PM +0200, Aya Mahfouz wrote: On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the

[PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) I used the following coccinelle script: @@ expression E1,E2;constant E3; @@ - memcpy(E1, E2, E3) + ether_addr_copy(E1, E2) pahole showed that the used

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Larry Finger
On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) I used the following coccinelle script: @@ expression E1,E2;constant E3; @@ - memcpy(E1, E2, E3) +

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Aya Mahfouz
On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: > On 01/28/2015 09:53 AM, Heba Aamer wrote: > >This patch fixes the following checkpatch.pl warning: > >Prefer ether_addr_copy() over memcpy() > >if the Ethernet addresses are __aligned(2) > > > >I used the following coccinelle script:

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Larry Finger
On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) I used the following coccinelle script: @@ expression E1,E2;constant E3; @@ - memcpy(E1, E2, E3) +

[PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Heba Aamer
This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) I used the following coccinelle script: @@ expression E1,E2;constant E3; @@ - memcpy(E1, E2, E3) + ether_addr_copy(E1, E2) pahole showed that the used

Re: [PATCH] staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()

2015-01-28 Thread Aya Mahfouz
On Wed, Jan 28, 2015 at 10:48:40AM -0600, Larry Finger wrote: On 01/28/2015 09:53 AM, Heba Aamer wrote: This patch fixes the following checkpatch.pl warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) I used the following coccinelle script: @@