Re: [PATCH] staging: rtl8712: switch to common ieee80211 headers

2020-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2020 at 04:58:46PM +0100, Pascal Terjan wrote: > On Tue, 2 Jun 2020 at 15:57, Larry Finger wrote: > > > > On 6/1/20 3:24 PM, Pascal Terjan wrote: > > > This patch switches to and and > > > deletes a lot of duplicate definitions plus many unused ones. > > > > > > Non obvious

Re: [PATCH] staging: rtl8712: switch to common ieee80211 headers

2020-06-02 Thread Pascal Terjan
On Tue, 2 Jun 2020 at 15:57, Larry Finger wrote: > > On 6/1/20 3:24 PM, Pascal Terjan wrote: > > This patch switches to and and > > deletes a lot of duplicate definitions plus many unused ones. > > > > Non obvious changes: > > - struct ieee80211_ht_cap is different enough that I preferred to

Re: [PATCH] staging: rtl8712: switch to common ieee80211 headers

2020-06-02 Thread kbuild test robot
Hi Pascal, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20200602] [cannot apply to v5.7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest

Re: [PATCH] staging: rtl8712: switch to common ieee80211 headers

2020-06-02 Thread Larry Finger
On 6/1/20 3:24 PM, Pascal Terjan wrote: This patch switches to and and deletes a lot of duplicate definitions plus many unused ones. Non obvious changes: - struct ieee80211_ht_cap is different enough that I preferred to keep (and rename) it for now. - mcs_rate in translate_scan was not

[PATCH] staging: rtl8712: switch to common ieee80211 headers

2020-06-01 Thread Pascal Terjan
This patch switches to and and deletes a lot of duplicate definitions plus many unused ones. Non obvious changes: - struct ieee80211_ht_cap is different enough that I preferred to keep (and rename) it for now. - mcs_rate in translate_scan was not read after being set, so I deleted that part