Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove unused variable ret

2017-09-18 Thread Greg KH
On Thu, Sep 14, 2017 at 10:21:29PM +0530, Harsha Sharma wrote: > Hi, > Yes, you are right but the function returns 0 in the end and the changes > compiles well . Then the function is incorrect, it should be reporting back that error. thanks, greg k-h

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove unused variable ret

2017-09-14 Thread Julia Lawall
On Thu, 14 Sep 2017, Harsha Sharma wrote: > Remove unused variable ret as it is not used anywhere. > Remove multiple blank lines. > Done using following coccinelle semantic patch > > @@ > type T; > identifier i; > constant C; > @@ > > ( > extern T i; > | > - T i; > <+... when != i > - i = C; >

[PATCH] staging: rtl8723bs: Remove unused variable ret

2017-09-14 Thread Harsha Sharma
Remove unused variable ret as it is not used anywhere. Remove multiple blank lines. Done using following coccinelle semantic patch @@ type T; identifier i; constant C; @@ ( extern T i; | - T i; <+... when != i - i = C; ...+> ) Signed-off-by: Harsha Sharma --- drivers/staging/rtl8723bs/os_d