Re: [PATCH] staging: rtl8723bs: align comments

2021-03-12 Thread Fabio Aiuto
On Wed, Mar 10, 2021 at 10:27:53PM +, Eric Curtin wrote: > Hi Fabio, > > > I am sorry, I fear I don't understand, checkpatch.sh script says the patch > > is ok. > > Where have I to add a ' ' (a blank?)? > > > > thank you, > > > > fabio > > > > I'm only responding to this because this email

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-11 Thread Fabio Aiuto
On Thu, Mar 11, 2021 at 01:15:34AM -0800, Joe Perches wrote: > On Wed, 2021-03-10 at 20:48 +0300, Dan Carpenter wrote: > > You need to have a space character after the '*'. > > Perhaps YA checkpatch test... > --- > scripts/checkpatch.pl | 15 +++ > 1 file changed, 15 insertions(+) >

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-11 Thread Fabio Aiuto
On Thu, Mar 11, 2021 at 09:03:57AM +0100, Miguel Ojeda wrote: > On Wed, Mar 10, 2021 at 11:00 PM Fabio Aiuto wrote: > > > > I am sorry, I fear I don't understand, checkpatch.sh script says the patch > > is ok. > > Where have I to add a ' ' (a blank?)? > > Please take a look at

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-11 Thread Joe Perches
On Wed, 2021-03-10 at 20:48 +0300, Dan Carpenter wrote: > You need to have a space character after the '*'. Perhaps YA checkpatch test... --- scripts/checkpatch.pl | 15 +++ 1 file changed, 15 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Fabio Aiuto
On Wed, Mar 10, 2021 at 10:27:53PM +, Eric Curtin wrote: > Hi Fabio, > > > I am sorry, I fear I don't understand, checkpatch.sh script says the patch > > is ok. > > Where have I to add a ' ' (a blank?)? > > > > thank you, > > > > fabio > > > > I'm only responding to this because this email

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Eric Curtin
Hi Fabio, > I am sorry, I fear I don't understand, checkpatch.sh script says the patch is > ok. > Where have I to add a ' ' (a blank?)? > > thank you, > > fabio > I'm only responding to this because this email is doing a very good job of avoiding my filters somehow :) I think what Greg means

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Fabio Aiuto
On Wed, Mar 10, 2021 at 04:51:44PM +0100, Greg KH wrote: > On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote: > > fix the following checkpatch warnings: > > > > WARNING: Block comments use * on subsequent lines > > + /* > > + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k,

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Dan Carpenter
On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote: > fix the following checkpatch warnings: > > WARNING: Block comments use * on subsequent lines > + /* > + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k > -- > WARNING: Block comments use * on subsequent

Re: [PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Greg KH
On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote: > fix the following checkpatch warnings: > > WARNING: Block comments use * on subsequent lines > + /* > + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k > -- > WARNING: Block comments use * on subsequent

[PATCH] staging: rtl8723bs: align comments

2021-03-10 Thread Fabio Aiuto
fix the following checkpatch warnings: WARNING: Block comments use * on subsequent lines + /* + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k -- WARNING: Block comments use * on subsequent lines +/* +op_mode Signed-off-by: Fabio Aiuto ---