Re: [PATCH] staging: rtlwifi: Fix potential NULL pointer dereference

2019-03-20 Thread Mukesh Ojha
On 3/13/2019 9:43 PM, Aditya Pakki wrote: phydm.internal is allocated using kzalloc which is used multiple times without a check for NULL pointer. This patch avoids such a scenario. Signed-off-by: Aditya Pakki --- drivers/staging/rtlwifi/phydm/rtl_phydm.c | 3 +++ 1 file changed, 3 insertio

Re: [PATCH] staging: rtlwifi: Fix potential NULL pointer dereference

2019-03-20 Thread Mukesh Ojha
On 3/13/2019 9:43 PM, Aditya Pakki wrote: phydm.internal is allocated using kzalloc which is used multiple times without a check for NULL pointer. This patch avoids such a scenario. Signed-off-by: Aditya Pakki --- drivers/staging/rtlwifi/phydm/rtl_phydm.c | 3 +++ 1 file changed, 3 inserti

Re: [PATCH] staging: rtlwifi: Fix potential NULL pointer dereference

2019-03-20 Thread Dan Carpenter
On Wed, Mar 13, 2019 at 11:13:34AM -0500, Aditya Pakki wrote: > phydm.internal is allocated using kzalloc which is used multiple > times without a check for NULL pointer. This patch avoids such a > scenario. > > Signed-off-by: Aditya Pakki > --- > drivers/staging/rtlwifi/phydm/rtl_phydm.c | 3 ++

Re: [PATCH] staging: rtlwifi: Fix potential NULL pointer dereference

2019-03-17 Thread Greg Kroah-Hartman
On Wed, Mar 13, 2019 at 11:29:12AM -0500, Aditya Pakki wrote: > skb allocated via dev_alloc_skb can fail and return a NULL pointer. > This patch avoids such a scenario and returns, consistent with other > invocations. > > Signed-off-by: Aditya Pakki > --- > drivers/staging/rtlwifi/rtl8822be/fw.c

[PATCH] staging: rtlwifi: Fix potential NULL pointer dereference

2019-03-13 Thread Aditya Pakki
skb allocated via dev_alloc_skb can fail and return a NULL pointer. This patch avoids such a scenario and returns, consistent with other invocations. Signed-off-by: Aditya Pakki --- drivers/staging/rtlwifi/rtl8822be/fw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rtlw

[PATCH] staging: rtlwifi: Fix potential NULL pointer dereference

2019-03-13 Thread Aditya Pakki
phydm.internal is allocated using kzalloc which is used multiple times without a check for NULL pointer. This patch avoids such a scenario. Signed-off-by: Aditya Pakki --- drivers/staging/rtlwifi/phydm/rtl_phydm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rtlwifi/phy