Re: [PATCH] staging: tidspbridge: pmgr: dspapi.c: Cleaning up uninitialized variables

2014-06-03 Thread Rickard Strandqvist
Hi I send in a new patch now, hope I interpreted you correctly how you wanted the changes. Worth mention is that in mgrwrap_enum_node_info() unless you wanted to remove "if (size < sizeof(struct dsp_ndbprops))" then size will always be the same as sizeof(struct dsp_ndbprops) Best regards Rick

Re: [PATCH] staging: tidspbridge: pmgr: dspapi.c: Cleaning up uninitialized variables

2014-06-02 Thread Dan Carpenter
[ I am writing this at the end after writing the rest of this email. After looking at the CP_TO_USR() macro more carefully, I realize that the uninitialized variable bugs you are fixing are false positives. The information leaks where the max size is not capped are real security bugs. T

[PATCH] staging: tidspbridge: pmgr: dspapi.c: Cleaning up uninitialized variables

2014-06-01 Thread Rickard Strandqvist
There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/tidspbridge/pmgr/dspapi.c |8 1 file changed, 4 insertions(+), 4 deletion