Re: [PATCH] staging: vboxvideo: make a couple of symbols static

2017-07-22 Thread Michael Thayer
22.07.2017 00:17, Hans de Goede wrote: > Hi, > > On 19-07-17 11:36, Colin King wrote: >> From: Colin Ian King >> >> Module parameter vbox_modeset and structure vbox_bo_driver do not need to >> be in global scope and hence can be made static. >> >> Cleans up a couple of

Re: [PATCH] staging: vboxvideo: make a couple of symbols static

2017-07-22 Thread Michael Thayer
22.07.2017 00:17, Hans de Goede wrote: > Hi, > > On 19-07-17 11:36, Colin King wrote: >> From: Colin Ian King >> >> Module parameter vbox_modeset and structure vbox_bo_driver do not need to >> be in global scope and hence can be made static. >> >> Cleans up a couple of sparse warnings: >> symbol

Re: [PATCH] staging: vboxvideo: make a couple of symbols static

2017-07-21 Thread Hans de Goede
Hi, On 19-07-17 11:36, Colin King wrote: From: Colin Ian King Module parameter vbox_modeset and structure vbox_bo_driver do not need to be in global scope and hence can be made static. Cleans up a couple of sparse warnings: symbol 'vbox_modeset' was not declared.

Re: [PATCH] staging: vboxvideo: make a couple of symbols static

2017-07-21 Thread Hans de Goede
Hi, On 19-07-17 11:36, Colin King wrote: From: Colin Ian King Module parameter vbox_modeset and structure vbox_bo_driver do not need to be in global scope and hence can be made static. Cleans up a couple of sparse warnings: symbol 'vbox_modeset' was not declared. Should it be static? symbol

[PATCH] staging: vboxvideo: make a couple of symbols static

2017-07-19 Thread Colin King
From: Colin Ian King Module parameter vbox_modeset and structure vbox_bo_driver do not need to be in global scope and hence can be made static. Cleans up a couple of sparse warnings: symbol 'vbox_modeset' was not declared. Should it be static? symbol 'vbox_bo_driver'

[PATCH] staging: vboxvideo: make a couple of symbols static

2017-07-19 Thread Colin King
From: Colin Ian King Module parameter vbox_modeset and structure vbox_bo_driver do not need to be in global scope and hence can be made static. Cleans up a couple of sparse warnings: symbol 'vbox_modeset' was not declared. Should it be static? symbol 'vbox_bo_driver' was not declared. Should it