Re: [PATCH] staging: vc04_services: rework ioctl code path

2016-11-09 Thread Arnd Bergmann
On Wednesday, November 9, 2016 12:37:27 PM CET Michael Zoran wrote: > static long > -vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > +vchiq_ioctl_shutdown(VCHIQ_INSTANCE_T instance, > + unsigned int cmd, > + unsigned long arg) { This does

Re: [PATCH] staging: vc04_services: rework ioctl code path

2016-11-09 Thread Arnd Bergmann
On Wednesday, November 9, 2016 12:37:27 PM CET Michael Zoran wrote: > static long > -vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > +vchiq_ioctl_shutdown(VCHIQ_INSTANCE_T instance, > + unsigned int cmd, > + unsigned long arg) { This does

[PATCH] staging: vc04_services: rework ioctl code path

2016-11-09 Thread Michael Zoran
VCHIQ/vc04_services has a userland device interface that includes ioctls. The current ioctl implementation is a single monolithic function over 1,000+ lines that handles 17 different ioctls through a complex maze of switch and if statements. The change reimplements that code path by breaking up

[PATCH] staging: vc04_services: rework ioctl code path

2016-11-09 Thread Michael Zoran
VCHIQ/vc04_services has a userland device interface that includes ioctls. The current ioctl implementation is a single monolithic function over 1,000+ lines that handles 17 different ioctls through a complex maze of switch and if statements. The change reimplements that code path by breaking up