Re: [PATCH] staging: vchiq: rework remove_event handling

2018-12-12 Thread Nicolas Saenz Julienne
On Tue, 2018-12-11 at 15:20 +0100, Arnd Bergmann wrote: > On Tue, Dec 11, 2018 at 1:36 PM Nicolas Saenz Julienne > wrote: > > On Mon, 2018-12-10 at 22:11 +0100, Arnd Bergmann wrote: > > > @@ -447,26 +444,26 @@ remote_event_wait(VCHIQ_STATE_T *state, > > > REMOTE_EVENT_T *event) > > > } > > > >

Re: [PATCH] staging: vchiq: rework remove_event handling

2018-12-11 Thread Arnd Bergmann
On Tue, Dec 11, 2018 at 1:36 PM Nicolas Saenz Julienne wrote: > On Mon, 2018-12-10 at 22:11 +0100, Arnd Bergmann wrote: > > @@ -447,26 +444,26 @@ remote_event_wait(VCHIQ_STATE_T *state, > > REMOTE_EVENT_T *event) > > } > > > > static inline void > > -remote_event_signal_local(VCHIQ_STATE_T

Re: [PATCH] staging: vchiq: rework remove_event handling

2018-12-11 Thread Arnd Bergmann
On Tue, Dec 11, 2018 at 1:31 PM Nicolas Saenz Julienne wrote: > > On Tue, 2018-12-11 at 13:07 +0300, Dan Carpenter wrote: > > On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote: > > > Note that I'm changing it back to 'killable' after the previous > > > patch > > > changed 'killable'

Re: [PATCH] staging: vchiq: rework remove_event handling

2018-12-11 Thread Nicolas Saenz Julienne
Hi Arnd, thanks for the patch! On Mon, 2018-12-10 at 22:11 +0100, Arnd Bergmann wrote: > I had started the removal of semaphores in this driver without > knowing > that Nicolas Saenz Julienne also worked on this. In case of the > "remote > event" infrastructure, my solution seemed significantly

Re: [PATCH] staging: vchiq: rework remove_event handling

2018-12-11 Thread Nicolas Saenz Julienne
On Tue, 2018-12-11 at 13:07 +0300, Dan Carpenter wrote: > On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote: > > Note that I'm changing it back to 'killable' after the previous > > patch > > changed 'killable' to 'interruptible', apparently based on a > > misunderstanding > > of the

Re: [PATCH] staging: vchiq: rework remove_event handling

2018-12-11 Thread Dan Carpenter
On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote: > Note that I'm changing it back to 'killable' after the previous patch > changed 'killable' to 'interruptible', apparently based on a misunderstanding > of the subtle down_interruptible() macro override in vchiq_killable.h. Oh wow...

[PATCH] staging: vchiq: rework remove_event handling

2018-12-10 Thread Arnd Bergmann
I had started the removal of semaphores in this driver without knowing that Nicolas Saenz Julienne also worked on this. In case of the "remote event" infrastructure, my solution seemed significantly better, so I'm proposing this as a change on top. The problem with using either semaphores or