Re: [PATCH] staging: vt6655: check for memory allocation failures

2018-03-28 Thread Ji-Hun Kim
On Wed, Mar 28, 2018 at 05:55:57PM +0800, Jia-Ju Bai wrote: > >@@ -646,7 +649,8 @@ static void device_init_td1_ring(struct vnt_private > >*priv) > > i++, curr += sizeof(struct vnt_tx_desc)) { > > desc = >apTD1Rings[i]; > > desc->td_info =

Re: [PATCH] staging: vt6655: check for memory allocation failures

2018-03-28 Thread Ji-Hun Kim
On Wed, Mar 28, 2018 at 05:55:57PM +0800, Jia-Ju Bai wrote: > >@@ -646,7 +649,8 @@ static void device_init_td1_ring(struct vnt_private > >*priv) > > i++, curr += sizeof(struct vnt_tx_desc)) { > > desc = >apTD1Rings[i]; > > desc->td_info =

Re: [PATCH] staging: vt6655: check for memory allocation failures

2018-03-28 Thread Jia-Ju Bai
On 2018/3/28 14:31, Ji-Hun Kim wrote: There are no null pointer checking on rd_info and td_info values which are allocated by kzalloc. It has potential null pointer dereferencing issues. Add return when allocation is failed. Signed-off-by: Ji-Hun Kim ---

Re: [PATCH] staging: vt6655: check for memory allocation failures

2018-03-28 Thread Jia-Ju Bai
On 2018/3/28 14:31, Ji-Hun Kim wrote: There are no null pointer checking on rd_info and td_info values which are allocated by kzalloc. It has potential null pointer dereferencing issues. Add return when allocation is failed. Signed-off-by: Ji-Hun Kim ---

Re: [PATCH] staging: vt6655: check for memory allocation failures

2018-03-28 Thread Greg KH
On Wed, Mar 28, 2018 at 03:31:31PM +0900, Ji-Hun Kim wrote: > There are no null pointer checking on rd_info and td_info values which > are allocated by kzalloc. It has potential null pointer dereferencing > issues. Add return when allocation is failed. > > Signed-off-by: Ji-Hun Kim

Re: [PATCH] staging: vt6655: check for memory allocation failures

2018-03-28 Thread Greg KH
On Wed, Mar 28, 2018 at 03:31:31PM +0900, Ji-Hun Kim wrote: > There are no null pointer checking on rd_info and td_info values which > are allocated by kzalloc. It has potential null pointer dereferencing > issues. Add return when allocation is failed. > > Signed-off-by: Ji-Hun Kim > --- >

[PATCH] staging: vt6655: check for memory allocation failures

2018-03-28 Thread Ji-Hun Kim
There are no null pointer checking on rd_info and td_info values which are allocated by kzalloc. It has potential null pointer dereferencing issues. Add return when allocation is failed. Signed-off-by: Ji-Hun Kim --- drivers/staging/vt6655/device_main.c | 12

[PATCH] staging: vt6655: check for memory allocation failures

2018-03-28 Thread Ji-Hun Kim
There are no null pointer checking on rd_info and td_info values which are allocated by kzalloc. It has potential null pointer dereferencing issues. Add return when allocation is failed. Signed-off-by: Ji-Hun Kim --- drivers/staging/vt6655/device_main.c | 12 1 file changed, 8