Re: [PATCH] staging: wfx: refactor to avoid duplication at hif_tx.c

2020-08-05 Thread kernel test robot
Hi Tomer, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Tomer-Samara/staging-wfx-refactor-to-avoid-duplication-at-hif_tx-c/20200805-165649 base:

Re: [PATCH] staging: wfx: refactor to avoid duplication at hif_tx.c

2020-08-05 Thread Tomer Samara
On Wed, Aug 05, 2020 at 11:04:25AM +0200, Greg KH wrote: > On Wed, Aug 05, 2020 at 11:56:08AM +0300, Tomer Samara wrote: > > Add functions wfx_full_send(), wfx_full_send_no_reply_async(), > > wfx_full_send_no_reply() and wfx_full_send_no_reply_free() > > which works as follow: > > wfx_full_send()

Re: [PATCH] staging: wfx: refactor to avoid duplication at hif_tx.c

2020-08-05 Thread Greg KH
On Wed, Aug 05, 2020 at 11:56:08AM +0300, Tomer Samara wrote: > Add functions wfx_full_send(), wfx_full_send_no_reply_async(), > wfx_full_send_no_reply() and wfx_full_send_no_reply_free() > which works as follow: > wfx_full_send() - simple wrapper for both wfx_fill_header() > and

[PATCH] staging: wfx: refactor to avoid duplication at hif_tx.c

2020-08-05 Thread Tomer Samara
Add functions wfx_full_send(), wfx_full_send_no_reply_async(), wfx_full_send_no_reply() and wfx_full_send_no_reply_free() which works as follow: wfx_full_send() - simple wrapper for both wfx_fill_header() and wfx_cmd_send(). wfx_full_send_no_reply_async() - wrapper for both but