Re: [PATCH] stop_machine: Mark functions as notrace

2020-11-05 Thread Guo Ren
On Tue, Nov 3, 2020 at 11:33 PM Atish Patra wrote: > > On Sat, Oct 31, 2020 at 12:42 AM Guo Ren wrote: > > > > On Sat, Oct 31, 2020 at 8:28 AM Steven Rostedt wrote: > > > > > > On Fri, 30 Oct 2020 14:47:56 -0700 > > > Atish Patra wrote: > > > > > > > > Look at arm64, they __kprobes flag and I

Re: [PATCH] stop_machine: Mark functions as notrace

2020-11-03 Thread Atish Patra
On Sat, Oct 31, 2020 at 12:42 AM Guo Ren wrote: > > On Sat, Oct 31, 2020 at 8:28 AM Steven Rostedt wrote: > > > > On Fri, 30 Oct 2020 14:47:56 -0700 > > Atish Patra wrote: > > > > > > Look at arm64, they __kprobes flag and I guess it would also prevent > > > > ftrace call site. > > > > > > > >

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-31 Thread Guo Ren
On Sat, Oct 31, 2020 at 8:28 AM Steven Rostedt wrote: > > On Fri, 30 Oct 2020 14:47:56 -0700 > Atish Patra wrote: > > > > Look at arm64, they __kprobes flag and I guess it would also prevent > > > ftrace call site. > > > > > > > Are you sure about that ? __kprobes puts the code in .kprobes.text

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-30 Thread Steven Rostedt
On Fri, 30 Oct 2020 14:47:56 -0700 Atish Patra wrote: > > Look at arm64, they __kprobes flag and I guess it would also prevent > > ftrace call site. > > > > Are you sure about that ? __kprobes puts the code in .kprobes.text section > which is under whitelist sections in recordmcount.pl &

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-30 Thread Atish Patra
On Thu, Oct 29, 2020 at 8:28 PM Guo Ren wrote: > > On Fri, Oct 30, 2020 at 2:46 AM Atish Patra wrote: > > > > On Thu, Oct 29, 2020 at 9:06 AM Guo Ren wrote: > > > > > > On Thu, Oct 29, 2020 at 10:34 AM Zong Li wrote: > > > > > > > > On Thu, Oct 29, 2020 at 8:23 AM Atish Patra > > > > wrote:

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-29 Thread Guo Ren
On Fri, Oct 30, 2020 at 2:46 AM Atish Patra wrote: > > On Thu, Oct 29, 2020 at 9:06 AM Guo Ren wrote: > > > > On Thu, Oct 29, 2020 at 10:34 AM Zong Li wrote: > > > > > > On Thu, Oct 29, 2020 at 8:23 AM Atish Patra wrote: > > > > > > > > On Wed, Oct 28, 2020 at 8:44 AM Guo Ren wrote: > > > > >

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-29 Thread Atish Patra
On Thu, Oct 29, 2020 at 9:06 AM Guo Ren wrote: > > On Thu, Oct 29, 2020 at 10:34 AM Zong Li wrote: > > > > On Thu, Oct 29, 2020 at 8:23 AM Atish Patra wrote: > > > > > > On Wed, Oct 28, 2020 at 8:44 AM Guo Ren wrote: > > > > > > > > Hi Zong & Atish, > > > > > > > > In our 2 harts c910 chip, we

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-29 Thread Guo Ren
On Thu, Oct 29, 2020 at 10:34 AM Zong Li wrote: > > On Thu, Oct 29, 2020 at 8:23 AM Atish Patra wrote: > > > > On Wed, Oct 28, 2020 at 8:44 AM Guo Ren wrote: > > > > > > Hi Zong & Atish, > > > > > > In our 2 harts c910 chip, we found: > > > > > > echo function >

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-29 Thread Guo Ren
On Thu, Oct 29, 2020 at 8:23 AM Atish Patra wrote: > > On Wed, Oct 28, 2020 at 8:44 AM Guo Ren wrote: > > > > Hi Zong & Atish, > > > > In our 2 harts c910 chip, we found: > > > > echo function > /sys/kernel/debug/tracing/current_tracer > > echo function_graph >

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-28 Thread Zong Li
On Thu, Oct 29, 2020 at 8:23 AM Atish Patra wrote: > > On Wed, Oct 28, 2020 at 8:44 AM Guo Ren wrote: > > > > Hi Zong & Atish, > > > > In our 2 harts c910 chip, we found: > > > > echo function > /sys/kernel/debug/tracing/current_tracer > > echo function_graph >

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-28 Thread Guo Ren
Hi Zong & Atish, In our 2 harts c910 chip, we found: echo function > /sys/kernel/debug/tracing/current_tracer echo function_graph > /sys/kernel/debug/tracing/current_tracer echo function > /sys/kernel/debug/tracing/current_tracer echo function_graph > /sys/kernel/debug/tracing/current_tracer

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-28 Thread Atish Patra
On Wed, Oct 28, 2020 at 8:44 AM Guo Ren wrote: > > Hi Zong & Atish, > > In our 2 harts c910 chip, we found: > > echo function > /sys/kernel/debug/tracing/current_tracer > echo function_graph > /sys/kernel/debug/tracing/current_tracer > echo function > /sys/kernel/debug/tracing/current_tracer >

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-25 Thread Zong Li
On Sat, Oct 24, 2020 at 3:29 AM Colin Ian King wrote: > > On 21/10/2020 08:38, Zong Li wrote: > > Like the commit cb9d7fd51d9f ("watchdog: Mark watchdog touch functions > > as notrace"), some architectures assume that the stopped CPUs don't make > > function calls to traceable functions when they

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-23 Thread Colin Ian King
On 21/10/2020 08:38, Zong Li wrote: > Like the commit cb9d7fd51d9f ("watchdog: Mark watchdog touch functions > as notrace"), some architectures assume that the stopped CPUs don't make > function calls to traceable functions when they are in the stopped > state. For example, it causes unexpected

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-21 Thread Atish Patra
On Wed, Oct 21, 2020 at 12:38 AM Zong Li wrote: > > Like the commit cb9d7fd51d9f ("watchdog: Mark watchdog touch functions > as notrace"), some architectures assume that the stopped CPUs don't make > function calls to traceable functions when they are in the stopped > state. For example, it

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-21 Thread Paul E. McKenney
On Wed, Oct 21, 2020 at 11:54:51AM -0400, Steven Rostedt wrote: > On Wed, 21 Oct 2020 08:44:56 -0700 > "Paul E. McKenney" wrote: > > > Or let me know if you would like me to take it, target v5.11. > > I'm not sure if these can wait, as I believe they are fixing a regression > with RISCV

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-21 Thread Steven Rostedt
On Wed, 21 Oct 2020 08:44:56 -0700 "Paul E. McKenney" wrote: > Or let me know if you would like me to take it, target v5.11. I'm not sure if these can wait, as I believe they are fixing a regression with RISCV function tracing. Probably best to have them go through the RISCV tree. -- Steve

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-21 Thread Paul E. McKenney
On Wed, Oct 21, 2020 at 10:15:22AM -0400, Steven Rostedt wrote: > On Wed, 21 Oct 2020 10:12:16 -0400 > Steven Rostedt wrote: > > > > Fixes: 4ecf0a43e729 ("processor: get rid of cpu_relax_yield") > > > Fixes: 366237e7b083 ("stop_machine: Provide RCU quiescent state in > > > multi_cpu_stop()") >

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-21 Thread Steven Rostedt
On Wed, 21 Oct 2020 10:12:16 -0400 Steven Rostedt wrote: > > Fixes: 4ecf0a43e729 ("processor: get rid of cpu_relax_yield") > > Fixes: 366237e7b083 ("stop_machine: Provide RCU quiescent state in > > multi_cpu_stop()") > > I really do not like to add "notrace" to core functions because a single

Re: [PATCH] stop_machine: Mark functions as notrace

2020-10-21 Thread Steven Rostedt
On Wed, 21 Oct 2020 15:38:39 +0800 Zong Li wrote: > Like the commit cb9d7fd51d9f ("watchdog: Mark watchdog touch functions > as notrace"), some architectures assume that the stopped CPUs don't make > function calls to traceable functions when they are in the stopped > state. For example, it

[PATCH] stop_machine: Mark functions as notrace

2020-10-21 Thread Zong Li
Like the commit cb9d7fd51d9f ("watchdog: Mark watchdog touch functions as notrace"), some architectures assume that the stopped CPUs don't make function calls to traceable functions when they are in the stopped state. For example, it causes unexpected kernel crashed when switching tracer on