Re: [PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-17 Thread Weijie Yang
On Thu, Oct 17, 2013 at 11:48 PM, Weijie Yang wrote: > On Wed, Oct 16, 2013 at 1:19 AM, Hugh Dickins wrote: >> On Tue, 15 Oct 2013, Krzysztof Kozlowski wrote: >>> On Tue, 2013-10-15 at 02:59 -0700, Hugh Dickins wrote: >>> > On Mon, 14 Oct 2013, Krzysztof Kozlowski wrote: >>> > >>> > > Fix race

Re: [PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-17 Thread Weijie Yang
On Wed, Oct 16, 2013 at 1:19 AM, Hugh Dickins wrote: > On Tue, 15 Oct 2013, Krzysztof Kozlowski wrote: >> On Tue, 2013-10-15 at 02:59 -0700, Hugh Dickins wrote: >> > On Mon, 14 Oct 2013, Krzysztof Kozlowski wrote: >> > >> > > Fix race between swapoff and swapon resulting in setting blocksize of

Re: [PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-17 Thread Weijie Yang
On Wed, Oct 16, 2013 at 1:19 AM, Hugh Dickins hu...@google.com wrote: On Tue, 15 Oct 2013, Krzysztof Kozlowski wrote: On Tue, 2013-10-15 at 02:59 -0700, Hugh Dickins wrote: On Mon, 14 Oct 2013, Krzysztof Kozlowski wrote: Fix race between swapoff and swapon resulting in setting blocksize

Re: [PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-17 Thread Weijie Yang
On Thu, Oct 17, 2013 at 11:48 PM, Weijie Yang weijie.yang...@gmail.com wrote: On Wed, Oct 16, 2013 at 1:19 AM, Hugh Dickins hu...@google.com wrote: On Tue, 15 Oct 2013, Krzysztof Kozlowski wrote: On Tue, 2013-10-15 at 02:59 -0700, Hugh Dickins wrote: On Mon, 14 Oct 2013, Krzysztof Kozlowski

Re: [PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-15 Thread Hugh Dickins
On Tue, 15 Oct 2013, Krzysztof Kozlowski wrote: > On Tue, 2013-10-15 at 02:59 -0700, Hugh Dickins wrote: > > On Mon, 14 Oct 2013, Krzysztof Kozlowski wrote: > > > > > Fix race between swapoff and swapon resulting in setting blocksize of > > > PAGE_SIZE for block devices during swapoff. > > > > >

Re: [PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-15 Thread Krzysztof Kozlowski
On Tue, 2013-10-15 at 02:59 -0700, Hugh Dickins wrote: > On Mon, 14 Oct 2013, Krzysztof Kozlowski wrote: > > > Fix race between swapoff and swapon resulting in setting blocksize of > > PAGE_SIZE for block devices during swapoff. > > > > The swapon modifies swap_info->old_block_size before

Re: [PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-15 Thread Hugh Dickins
On Mon, 14 Oct 2013, Krzysztof Kozlowski wrote: > Fix race between swapoff and swapon resulting in setting blocksize of > PAGE_SIZE for block devices during swapoff. > > The swapon modifies swap_info->old_block_size before acquiring > swapon_mutex. It reads block_size of bdev, stores it under >

Re: [PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-15 Thread Hugh Dickins
On Mon, 14 Oct 2013, Krzysztof Kozlowski wrote: Fix race between swapoff and swapon resulting in setting blocksize of PAGE_SIZE for block devices during swapoff. The swapon modifies swap_info-old_block_size before acquiring swapon_mutex. It reads block_size of bdev, stores it under

Re: [PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-15 Thread Krzysztof Kozlowski
On Tue, 2013-10-15 at 02:59 -0700, Hugh Dickins wrote: On Mon, 14 Oct 2013, Krzysztof Kozlowski wrote: Fix race between swapoff and swapon resulting in setting blocksize of PAGE_SIZE for block devices during swapoff. The swapon modifies swap_info-old_block_size before acquiring

Re: [PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-15 Thread Hugh Dickins
On Tue, 15 Oct 2013, Krzysztof Kozlowski wrote: On Tue, 2013-10-15 at 02:59 -0700, Hugh Dickins wrote: On Mon, 14 Oct 2013, Krzysztof Kozlowski wrote: Fix race between swapoff and swapon resulting in setting blocksize of PAGE_SIZE for block devices during swapoff. The swapon

[PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-14 Thread Krzysztof Kozlowski
Fix race between swapoff and swapon resulting in setting blocksize of PAGE_SIZE for block devices during swapoff. The swapon modifies swap_info->old_block_size before acquiring swapon_mutex. It reads block_size of bdev, stores it under swap_info->old_block_size and sets new block_size to

[PATCH] swap: fix setting PAGE_SIZE blocksize during swapoff/swapon race

2013-10-14 Thread Krzysztof Kozlowski
Fix race between swapoff and swapon resulting in setting blocksize of PAGE_SIZE for block devices during swapoff. The swapon modifies swap_info-old_block_size before acquiring swapon_mutex. It reads block_size of bdev, stores it under swap_info-old_block_size and sets new block_size to PAGE_SIZE.