Sorry for delay,
On 02/06, Hugh Dickins wrote:
>
> On Sun, 3 Feb 2008, Oleg Nesterov wrote:
> > Off-topic question to all. sys_remap_file_pages() doesn't work with
> > shared readonly mappings, why?
>
> Slight correction: it works with shared readonly mappings, doesn't
> it, so long as the mmap'
On Wed, 6 Feb 2008, Matt Helsley wrote:
> On Wed, 2008-02-06 at 20:33 +, Hugh Dickins wrote:
> >
> > Sorry, Matt, I don't like your patch at all. It seems to add a fair
> > amount of ugliness and unmaintainablity, all for a peculiar MVFS case
>
> I thought that getting rid of the separate ve
On Wed, 2008-02-06 at 20:33 +, Hugh Dickins wrote:
> On Sun, 3 Feb 2008, Oleg Nesterov wrote:
> >
> > So I have to try to find another bug ;) Suppose that ->load_binary() does
> > a series of do_mmap(MAP_EXECUTABLE). It is possible that mmap_region() can
> > merge 2 vmas. In that case we "lea
On Sun, 3 Feb 2008, Oleg Nesterov wrote:
>
> So I have to try to find another bug ;) Suppose that ->load_binary() does
> a series of do_mmap(MAP_EXECUTABLE). It is possible that mmap_region() can
> merge 2 vmas. In that case we "leak" ->num_exe_file_vmas. Unless I missed
> something, mmap_region()
[ removed stable ]
On Sun, 3 Feb 2008, Oleg Nesterov wrote:
> Off-topic question to all. sys_remap_file_pages() doesn't work with
> shared readonly mappings, why?
Slight correction: it works with shared readonly mappings, doesn't
it, so long as the mmap'ed file was opened for reading and writing?
Off-topic question to all. sys_remap_file_pages() doesn't work with
shared readonly mappings, why?
IOW, why it checks VM_SHARED but not VM_MAYSHARE?
Thanks in advance,
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
(remove [EMAIL PROTECTED] from CC)
On 02/02, Matt Helsley wrote:
>
> On Wed, 2008-01-30 at 20:26 +0300, Oleg Nesterov wrote:
> >
> > Offtopic. I noticed this problem while looking at this patch:
> >
> > http://marc.info/?l=linux-mm-commits&m=120141116911711
> >
> > So this (the old vma cou
On Wed, 2008-01-30 at 20:26 +0300, Oleg Nesterov wrote:
> On 01/30, Miklos Szeredi wrote:
> >
> > On Wed, 2008-01-30 at 17:20 +0300, Oleg Nesterov wrote:
> > > Fix ->vm_file accounting, mmap_region() may do do_munmap().
> >
> > There's a small problem with the patch: the vma itself is freed at
>
On Wed, 2008-01-30 at 20:26 +0300, Oleg Nesterov wrote:
> On 01/30, Miklos Szeredi wrote:
> >
> > On Wed, 2008-01-30 at 17:20 +0300, Oleg Nesterov wrote:
> > > Fix ->vm_file accounting, mmap_region() may do do_munmap().
> >
> > There's a small problem with the patch: the vma itself is freed at
>
On 01/30, Miklos Szeredi wrote:
>
> On Wed, 2008-01-30 at 17:20 +0300, Oleg Nesterov wrote:
> > Fix ->vm_file accounting, mmap_region() may do do_munmap().
>
> There's a small problem with the patch: the vma itself is freed at
> unmap, so the fput(vma->vm_file) may crash. Here's an updated patch
On Wed, 2008-01-30 at 17:20 +0300, Oleg Nesterov wrote:
> Fix ->vm_file accounting, mmap_region() may do do_munmap().
Ouch! I didn't think of that case at all...
There's a small problem with the patch: the vma itself is freed at
unmap, so the fput(vma->vm_file) may crash. Here's an updated pat
Fix ->vm_file accounting, mmap_region() may do do_munmap().
Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]>
--- MM/mm/fremap.c~RFP 2007-10-25 16:22:12.0 +0400
+++ MM/mm/fremap.c 2008-01-30 16:56:39.0 +0300
@@ -192,8 +192,10 @@ asmlinkage long sys_remap_file_pages(uns
12 matches
Mail list logo
