Re: [PATCH] sysctl: redefine zero as a unsigned long

2019-04-05 Thread Hou Tao
Hi, Cc Andrew for patch inclusion On 2019/4/6 0:27, Matthew Wilcox wrote: > On Fri, Apr 05, 2019 at 02:52:17PM +0800, Hou Tao wrote: >> We have got KASAN splat when tried to set /proc/sys/fs/file-max: > > Matteo Croce already has a patch in-flight for this. > > Yes, I find it now:

Re: [PATCH] sysctl: redefine zero as a unsigned long

2019-04-05 Thread Matthew Wilcox
On Fri, Apr 05, 2019 at 02:52:17PM +0800, Hou Tao wrote: > We have got KASAN splat when tried to set /proc/sys/fs/file-max: Matteo Croce already has a patch in-flight for this.

Re: [PATCH] sysctl: redefine zero as a unsigned long

2019-04-05 Thread Kees Cook
On Thu, Apr 4, 2019 at 11:48 PM Hou Tao wrote: > > We have got KASAN splat when tried to set /proc/sys/fs/file-max: > > BUG: KASAN: global-out-of-bounds in __do_proc_doulongvec_minmax+0x3e4/0x8f0 > Read of size 8 at addr 2f9b2980 by task file-max.sh/36819 > > Call trace: >

[PATCH] sysctl: redefine zero as a unsigned long

2019-04-05 Thread Hou Tao
We have got KASAN splat when tried to set /proc/sys/fs/file-max: BUG: KASAN: global-out-of-bounds in __do_proc_doulongvec_minmax+0x3e4/0x8f0 Read of size 8 at addr 2f9b2980 by task file-max.sh/36819 Call trace: dump_backtrace+0x0/0x3f8 show_stack+0x3c/0x60