Re: [PATCH] sysfs: fix namespace refcnt leak

2014-02-20 Thread Tejun Heo
Hello, Li. On Wed, Feb 19, 2014 at 09:39:28AM +0800, Li Zefan wrote: > > Can we make it optional so that users who don't care about it can > > ignore it? > > cgroupfs also needs this to fix refcnt leak. Ah, okay. > Because success in finding an existing cgroup_root doesn't mean no new >

Re: [PATCH] sysfs: fix namespace refcnt leak

2014-02-20 Thread Tejun Heo
Hello, Li. On Wed, Feb 19, 2014 at 09:39:28AM +0800, Li Zefan wrote: Can we make it optional so that users who don't care about it can ignore it? cgroupfs also needs this to fix refcnt leak. Ah, okay. Because success in finding an existing cgroup_root doesn't mean no new superblock is

Re: [PATCH] sysfs: fix namespace refcnt leak

2014-02-18 Thread Li Zefan
On 2014/2/19 7:12, Tejun Heo wrote: > Hey, > > On Mon, Feb 17, 2014 at 11:54:59AM +0800, Li Zefan wrote: >> I think we have to fix kernfs in order to fix refcnt leak in sysfs >> and cgroupfs. This fix is for 3.14, but it creates conflicts for >> cgroup-next. >> >> >> >> As

Re: [PATCH] sysfs: fix namespace refcnt leak

2014-02-18 Thread Tejun Heo
Hey, On Mon, Feb 17, 2014 at 11:54:59AM +0800, Li Zefan wrote: > I think we have to fix kernfs in order to fix refcnt leak in sysfs > and cgroupfs. This fix is for 3.14, but it creates conflicts for > cgroup-next. > > > > As mount() and kill_sb() is not a one-to-one match,

Re: [PATCH] sysfs: fix namespace refcnt leak

2014-02-18 Thread Tejun Heo
Hey, On Mon, Feb 17, 2014 at 11:54:59AM +0800, Li Zefan wrote: I think we have to fix kernfs in order to fix refcnt leak in sysfs and cgroupfs. This fix is for 3.14, but it creates conflicts for cgroup-next. As mount() and kill_sb() is not a one-to-one match, we

Re: [PATCH] sysfs: fix namespace refcnt leak

2014-02-18 Thread Li Zefan
On 2014/2/19 7:12, Tejun Heo wrote: Hey, On Mon, Feb 17, 2014 at 11:54:59AM +0800, Li Zefan wrote: I think we have to fix kernfs in order to fix refcnt leak in sysfs and cgroupfs. This fix is for 3.14, but it creates conflicts for cgroup-next. As mount() and

[PATCH] sysfs: fix namespace refcnt leak

2014-02-16 Thread Li Zefan
Hi Tejun, I think we have to fix kernfs in order to fix refcnt leak in sysfs and cgroupfs. This fix is for 3.14, but it creates conflicts for cgroup-next. As mount() and kill_sb() is not a one-to-one match, we shoudn't get ns refcnt unconditionally in sysfs_mount(), and

[PATCH] sysfs: fix namespace refcnt leak

2014-02-16 Thread Li Zefan
Hi Tejun, I think we have to fix kernfs in order to fix refcnt leak in sysfs and cgroupfs. This fix is for 3.14, but it creates conflicts for cgroup-next. As mount() and kill_sb() is not a one-to-one match, we shoudn't get ns refcnt unconditionally in sysfs_mount(), and