Re: [PATCH] sysfs: replace WARN() with pr_debug in sysfs_remove_group()

Grep, On 2017/8/2 2:06, Greg KH wrote: On Tue, Aug 01, 2017 at 05:02:25PM +0900, Ethan Zhao wrote: There is no enough error handling in block device adding/registration path, for example, device_add_disk() blk_register_queue() When kernel returns from device_add_disk(), no return value to

Re: [PATCH] sysfs: replace WARN() with pr_debug in sysfs_remove_group()

On Tue, Aug 01, 2017 at 05:02:25PM +0900, Ethan Zhao wrote: > There is no enough error handling in block device adding/registration > path, for example, > > device_add_disk() > blk_register_queue() > > When kernel returns from device_add_disk(), no return value to tell > us it was successful or

[PATCH] sysfs: replace WARN() with pr_debug in sysfs_remove_group()

There is no enough error handling in block device adding/registration path, for example, device_add_disk() blk_register_queue() When kernel returns from device_add_disk(), no return value to tell us it was successful or not --- that suggests it would always succeed, and according to this assump