Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Em Fri, Mar 23, 2018 at 04:55:13PM +0100, Sebastian Andrzej Siewior escreveu: > Arnaldo, please do "[PATCH RT]" while sending patches. Then the bots > don't complain if it applies but does not compile on !RT kernel (or so > I've been told). Ok, I'll try to remember that for future patches. -

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Em Fri, Mar 23, 2018 at 04:55:13PM +0100, Sebastian Andrzej Siewior escreveu: > Arnaldo, please do "[PATCH RT]" while sending patches. Then the bots > don't complain if it applies but does not compile on !RT kernel (or so > I've been told). Ok, I'll try to remember that for future patches. -

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Fri, Mar 23, 2018 at 9:25 AM, Bart Van Assche wrote: > > Have you considered to delete the WARN_ON_ONCE(!irqs_disabled()) statement? > I think that check duplicates functionality that already exists in lockdep > since lockdep is already able to detect spinlock use

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Fri, Mar 23, 2018 at 9:25 AM, Bart Van Assche wrote: > > Have you considered to delete the WARN_ON_ONCE(!irqs_disabled()) statement? > I think that check duplicates functionality that already exists in lockdep > since lockdep is already able to detect spinlock use inconsistencies. Please just

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On 2018-03-23 16:25:25 [+], Bart Van Assche wrote: > On Fri, 2018-03-23 at 16:55 +0100, Sebastian Andrzej Siewior wrote: > > I am going take this into -RT tree for now until we have different > > solution. > > Have you considered to delete the WARN_ON_ONCE(!irqs_disabled()) statement? > I

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On 2018-03-23 16:25:25 [+], Bart Van Assche wrote: > On Fri, 2018-03-23 at 16:55 +0100, Sebastian Andrzej Siewior wrote: > > I am going take this into -RT tree for now until we have different > > solution. > > Have you considered to delete the WARN_ON_ONCE(!irqs_disabled()) statement? > I

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Fri, 2018-03-23 at 16:55 +0100, Sebastian Andrzej Siewior wrote: > I am going take this into -RT tree for now until we have different > solution. Have you considered to delete the WARN_ON_ONCE(!irqs_disabled()) statement? I think that check duplicates functionality that already exists in

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Fri, 2018-03-23 at 16:55 +0100, Sebastian Andrzej Siewior wrote: > I am going take this into -RT tree for now until we have different > solution. Have you considered to delete the WARN_ON_ONCE(!irqs_disabled()) statement? I think that check duplicates functionality that already exists in

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On 2018-03-22 06:37:45 [-0300], Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > >

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On 2018-03-22 06:37:45 [-0300], Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > > wrote: > > > > > >

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Hi Arnaldo, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Hi Arnaldo, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Hi Arnaldo, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Hi Arnaldo, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Thu, 22 Mar 2018, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > > wrote: > > >

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Thu, 22 Mar 2018, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > > wrote: > > > > > >

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Em Thu, Mar 22, 2018 at 06:37:45AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > >

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Em Thu, Mar 22, 2018 at 06:37:45AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > > wrote:

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > wrote: > > > > assert_spin_locked(>t_state_lock); > > -

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > wrote: > > > > assert_spin_locked(>t_state_lock); > > -

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Wed, 21 Mar 2018, Linus Torvalds wrote: > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > wrote: > > > > assert_spin_locked(>t_state_lock); > > -

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Wed, 21 Mar 2018, Linus Torvalds wrote: > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > wrote: > > > > assert_spin_locked(>t_state_lock); > > - WARN_ON_ONCE(!irqs_disabled()); > > +

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Wed, 21 Mar 2018 11:50:01 -0700 Christoph Hellwig wrote: > On Wed, Mar 21, 2018 at 12:38:54PM -0300, Arnaldo Carvalho de Melo wrote: > > assert_spin_locked(>t_state_lock); > > - WARN_ON_ONCE(!irqs_disabled()); > > + WARN_ON_ONCE_NONRT(!irqs_disabled()); > > I

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Wed, 21 Mar 2018 11:50:01 -0700 Christoph Hellwig wrote: > On Wed, Mar 21, 2018 at 12:38:54PM -0300, Arnaldo Carvalho de Melo wrote: > > assert_spin_locked(>t_state_lock); > > - WARN_ON_ONCE(!irqs_disabled()); > > + WARN_ON_ONCE_NONRT(!irqs_disabled()); > > I can't find where

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Wed, Mar 21, 2018 at 12:38:54PM -0300, Arnaldo Carvalho de Melo wrote: > assert_spin_locked(>t_state_lock); > - WARN_ON_ONCE(!irqs_disabled()); > + WARN_ON_ONCE_NONRT(!irqs_disabled()); I can't find where WARN_ON_ONCE_NONRT is defined. That being said I think we can just kill

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Wed, Mar 21, 2018 at 12:38:54PM -0300, Arnaldo Carvalho de Melo wrote: > assert_spin_locked(>t_state_lock); > - WARN_ON_ONCE(!irqs_disabled()); > + WARN_ON_ONCE_NONRT(!irqs_disabled()); I can't find where WARN_ON_ONCE_NONRT is defined. That being said I think we can just kill

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

[ Adding PeterZ to participants due to query about lockdep_assert() ] On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo wrote: > > assert_spin_locked(>t_state_lock); > - WARN_ON_ONCE(!irqs_disabled()); > + WARN_ON_ONCE_NONRT(!irqs_disabled()); Ugh.

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

[ Adding PeterZ to participants due to query about lockdep_assert() ] On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo wrote: > > assert_spin_locked(>t_state_lock); > - WARN_ON_ONCE(!irqs_disabled()); > + WARN_ON_ONCE_NONRT(!irqs_disabled()); Ugh. Can't we just

[PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Hi, We got a report where this WARN_ON got triggered: [ 7552.77] [ cut here ] [ 7552.800016] WARNING: CPU: 7 PID: 1090 at drivers/target/target_core_transport.c:3009 __transport_check_aborted_status+0x153/0x190 [target_core_mod] [ 7552.800037] Modules linked

[PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

Hi, We got a report where this WARN_ON got triggered: [ 7552.77] [ cut here ] [ 7552.800016] WARNING: CPU: 7 PID: 1090 at drivers/target/target_core_transport.c:3009 __transport_check_aborted_status+0x153/0x190 [target_core_mod] [ 7552.800037] Modules linked