On Sat, Oct 17 2020 at 15:03, Jens Axboe wrote:
> On 10/17/20 3:01 PM, Thomas Gleixner wrote:
>> Sure. I assume you ship it to Linus, otherwise let me know and I'll pick
>> it up.
>
> I can, I have it bundled up with the TIF_NOTIFY_RESUME cleanup. Either
> way is fine with me, so if you're good
On 10/17/20 3:01 PM, Thomas Gleixner wrote:
> Jens,
>
> On Sat, Oct 17 2020 at 14:32, Jens Axboe wrote:
>> On 10/17/20 2:18 PM, Thomas Gleixner wrote:
>>
>> Thanks! Fixed the two typos, and also included the guest mode. If you're fine
>> with it now, would be great to have your reviewed-by or
Jens,
On Sat, Oct 17 2020 at 14:32, Jens Axboe wrote:
> On 10/17/20 2:18 PM, Thomas Gleixner wrote:
>
> Thanks! Fixed the two typos, and also included the guest mode. If you're fine
> with it now, would be great to have your reviewed-by or similar.
Sure. I assume you ship it to Linus, otherwise
On 10/17/20 2:18 PM, Thomas Gleixner wrote:
> On Sat, Oct 17 2020 at 09:36, Jens Axboe wrote:
>> diff --git a/kernel/task_work.c b/kernel/task_work.c
>> index 613b2d634af8..d82c224ab5d5 100644
>> --- a/kernel/task_work.c
>> +++ b/kernel/task_work.c
>> @@ -9,23 +9,28 @@ static struct callback_head
On Sat, Oct 17 2020 at 09:36, Jens Axboe wrote:
> diff --git a/kernel/task_work.c b/kernel/task_work.c
> index 613b2d634af8..d82c224ab5d5 100644
> --- a/kernel/task_work.c
> +++ b/kernel/task_work.c
> @@ -9,23 +9,28 @@ static struct callback_head work_exited; /* all we need is
> ->next == NULL */
On 10/17/20 9:31 AM, Thomas Gleixner wrote:
> On Fri, Oct 16 2020 at 17:43, Jens Axboe wrote:
>> On 10/16/20 5:38 PM, Thomas Gleixner wrote:
>> If you know the task isn't exiting, then yeah you can ignore it. But
>> seems a bit dicey...
>
> Indeed.
>
>>> fs/io_uring.c- if (unlikely(ret)) {
On Fri, Oct 16 2020 at 17:43, Jens Axboe wrote:
> On 10/16/20 5:38 PM, Thomas Gleixner wrote:
> If you know the task isn't exiting, then yeah you can ignore it. But
> seems a bit dicey...
Indeed.
>> fs/io_uring.c- if (unlikely(ret)) {
>> fs/io_uring.c- struct task_struct
On 10/16/20 5:38 PM, Thomas Gleixner wrote:
> On Fri, Oct 16 2020 at 17:13, Jens Axboe wrote:
>> /**
>> * task_work_add - ask the @task to execute @work->func()
>> * @task: the task which should run the callback
>> * @work: the callback to run
>> * @notify: how to notify the targeted task
>>
On Fri, Oct 16 2020 at 17:13, Jens Axboe wrote:
> /**
> * task_work_add - ask the @task to execute @work->func()
> * @task: the task which should run the callback
> * @work: the callback to run
> * @notify: how to notify the targeted task
> *
> * Queue @work for task_work_run() below and
On 10/16/20 5:09 PM, Thomas Gleixner wrote:
> On Fri, Oct 16 2020 at 16:39, Jens Axboe wrote:
>> On 10/16/20 3:44 PM, Thomas Gleixner wrote:
- * @notify: send the notification if true
+ * @notify: send chosen notification, if any
>>>
>>> Is that really all you found to be wrong in that
On Fri, Oct 16 2020 at 16:39, Jens Axboe wrote:
> On 10/16/20 3:44 PM, Thomas Gleixner wrote:
>>> - * @notify: send the notification if true
>>> + * @notify: send chosen notification, if any
>>
>> Is that really all you found to be wrong in that comment?
>
> There really is nothing wrong, but
On 10/16/20 3:44 PM, Thomas Gleixner wrote:
> On Fri, Oct 16 2020 at 09:16, Jens Axboe wrote:
>> A previous commit changed the notification mode from 0/1 to allowing
>
> No. It changed it from boolean to an int.
>
> There is a fundamental difference between 0/1 and false/true simply
> because
On Fri, Oct 16 2020 at 09:16, Jens Axboe wrote:
> A previous commit changed the notification mode from 0/1 to allowing
No. It changed it from boolean to an int.
There is a fundamental difference between 0/1 and false/true simply
because it's a compiler implementation detail how to represent a
A previous commit changed the notification mode from 0/1 to allowing
0/1/TWA_SIGNAL. Clean this up properly, and define a proper enum for
the notification mode. Now we have:
- TWA_NONE. This is 0, same as before the original change, meaning no
notification requested.
- TWA_RESUME. This is 1,
14 matches
Mail list logo
